Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js #50795

Merged
merged 1 commit into from
Nov 24, 2023
Merged

test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js #50795

merged 1 commit into from
Nov 24, 2023

Conversation

StiffWriter00
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55781/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55818/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8c72210 into nodejs:main Nov 24, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8c72210

martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@StiffWriter00 @martenrichter
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
b8b8044 
PR-URL: nodejs#50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@StiffWriter00
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
247915b 
PR-URL: nodejs#50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@StiffWriter00 @RafaelGSS
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
46bfdf4 
PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@StiffWriter00 @RafaelGSS
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
7f44164 
PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@StiffWriter00 @RafaelGSS
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
daef3d1 
PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
9f5860f 
PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
04717bd 
PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
0ad36c2 
PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@StiffWriter00 @UlisesGascon
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
96143a3 
PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@StiffWriter00 @nodejs-github-bot @jasnell @lpinca @marco-ippolito @RafaelGSS