Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix links order in Buffer doc #5076

Closed
wants to merge 1 commit into from
Closed

doc: fix links order in Buffer doc #5076

wants to merge 1 commit into from

Conversation

estliberitas
Copy link
Contributor

Sort links in lexical order

Sort links in lexical order
@thefourtheye thefourtheye added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Feb 4, 2016
@@ -75,8 +75,8 @@ The character encodings currently supported by Node.js include:
Buffers are also `Uint8Array` TypedArray instances. However, there are subtle
incompatibilities with the TypedArray specification in ECMAScript 2015. For
instance, while `ArrayBuffer#slice()` creates a copy of the slice,
the implementation of [`Buffer#slice()`][] creates a view over the existing
Buffer without copying, making `Buffer#slice()` far more efficient.
the implementation of [`Buffer#slice()`][`buf.slice()`] creates a view over the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the reference also has backticks? :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, since it points to buf.slice() reference. I could do something like [buf-slice] and use it in both cases. But this way I guess I saved some characters ))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@thefourtheye
Copy link
Contributor

LGTM cc @nodejs/documentation

@DavidTPate
Copy link

LGTM

1 similar comment
@r-52
Copy link
Contributor

r-52 commented Feb 4, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

Landed in c714b2e

@jasnell jasnell closed this Feb 4, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 9, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@stevemao
Copy link
Contributor

stevemao commented Feb 9, 2016

@estliberitas you should probably join the documentation group incase you are not aware of it.

@estliberitas
Copy link
Contributor Author

@stevemao Em, I'm not aware of this. It's not up to me as far as I recall

@stevemao
Copy link
Contributor

MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@estliberitas estliberitas deleted the doc-buffer-link-order branch February 27, 2016 18:49
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Sort links in lexical order

PR-URL: #5076
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Sort links in lexical order

PR-URL: nodejs#5076
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants