Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v21.2.0 release proposal #50681

Merged
merged 144 commits into from
Nov 14, 2023
Merged

v21.2.0 release proposal #50681

merged 144 commits into from
Nov 14, 2023

Commits on Nov 11, 2023

  1. test_runner: add Date to the supported mock APIs

    signed-off-by: Lucas Santos <[email protected]>
    PR-URL: #48638
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Erick Wendel <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    khaosdoctor authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f6c4965 View commit details
    Browse the repository at this point in the history
  2. stream: avoid getter for defaultEncoding

    PR-URL: #50203
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    766bd9c View commit details
    Browse the repository at this point in the history
  3. perf_hooks: reduce overhead of createHistogram

    PR-URL: #50074
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    H4ad authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    905ca00 View commit details
    Browse the repository at this point in the history
  4. test: avoid v8 deadcode on performance function

    PR-URL: #50074
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    H4ad authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    ad31641 View commit details
    Browse the repository at this point in the history
  5. meta: mention other notable changes section

    PR-URL: #50309
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    RafaelGSS authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    e008336 View commit details
    Browse the repository at this point in the history
  6. tools: update lint-md-dependencies

    - @rollup/[email protected]
    - @rollup/[email protected]
    - [email protected]
    
    PR-URL: #50190
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    bd46348 View commit details
    Browse the repository at this point in the history
  7. src: add commit hash shorthand in zlib version

    src: add commit hash shorthand in zlib version
    PR-URL: #50158
    Fixes: #50139
    Reviewed-By: Marco Ippolito <[email protected]>
    MrJithil authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    541bdf1 View commit details
    Browse the repository at this point in the history
  8. fs: do not throw error on cpSync internals

    PR-URL: #50185
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    anonrig authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    3e7226a View commit details
    Browse the repository at this point in the history
  9. test: ensure never settling promises are detected

    PR-URL: #50318
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    aduh95 authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    31cd05c View commit details
    Browse the repository at this point in the history
  10. benchmark: move permission-fs-read to permission-processhas-fs-read

    PR-URL: #49770
    Reviewed-By: Rafael Gonzaga <[email protected]>
    aki0501 authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    800206b View commit details
    Browse the repository at this point in the history
  11. deps: update googletest to 116b7e5

    PR-URL: #50324
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d6f49c7 View commit details
    Browse the repository at this point in the history
  12. tools: update eslint to 8.52.0

    PR-URL: #50326
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    5ccdda4 View commit details
    Browse the repository at this point in the history
  13. benchmark: skip test-benchmark-os on IBMi

    - IBMi does not have the os.uptime implemented so skip
      otherwise CI tests fail.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #50286
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    mhdawson authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    2006b57 View commit details
    Browse the repository at this point in the history
  14. benchmark: add more cases to Readable.from

    PR-URL: #50351
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    rluvaton authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c4b6e1e View commit details
    Browse the repository at this point in the history
  15. stream: refactor writable _write

    PR-URL: #50198
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f56ae67 View commit details
    Browse the repository at this point in the history
  16. deps: update llhttp to 9.1.3

    PR-URL: #50080
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    nodejs-github-bot authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    62515e1 View commit details
    Browse the repository at this point in the history
  17. src: use find instead of char-by-char in FromFilePath()

    PR-URL: #50288
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    lemire authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f1d79b3 View commit details
    Browse the repository at this point in the history
  18. build: fix building when there is only python3

    PR-URL: #48462
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    zcbenz authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    54ebfc1 View commit details
    Browse the repository at this point in the history
  19. test_runner: test return value of mocked promisified timers

    PR-URL: #50331
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Erick Wendel <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    mika-fischer authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    e2c3b01 View commit details
    Browse the repository at this point in the history
  20. stream: optimize creation

    Refs: nodejs/performance#79
    
    PR-URL: #50337
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    e433fa5 View commit details
    Browse the repository at this point in the history
  21. doc: fix TOC in releases.md

    Fixes: #50368
    PR-URL: #50372
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    bryce-seefieldt authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d9f92bc View commit details
    Browse the repository at this point in the history
  22. test_runner: adds built in lcov reporter

    Fixes #49626
    
    PR-URL: #50018
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    philnash authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c9b92bb View commit details
    Browse the repository at this point in the history
  23. stream: use Array for Readable buffer

    PR-URL: #50341
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    65850a6 View commit details
    Browse the repository at this point in the history
  24. doc: add Ethan-Arrowood as a collaborator

    PR-URL: #50393
    Fixes: #50170
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Ethan Arrowood authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f236657 View commit details
    Browse the repository at this point in the history
  25. src: implement structuredClone in native

    Simplify the implementation by implementing it directly in C++.
    This improves performance and also makes structuredClone supported
    in custom snapshots.
    
    PR-URL: #50330
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Daeyeon Jeong <[email protected]>
    joyeecheung authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    5b453d4 View commit details
    Browse the repository at this point in the history
  26. benchmark: add benchmarks for encodings

    PR-URL: #50348
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Uzlopak authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    3f37ed9 View commit details
    Browse the repository at this point in the history
  27. tools: run coverage CI only on relevant files

    PR-URL: #50349
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    aduh95 authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f210915 View commit details
    Browse the repository at this point in the history
  28. stream: readable use bitmap accessors

    PR-URL: #50350
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    586ec48 View commit details
    Browse the repository at this point in the history
  29. doc: add information about Node-API versions >=9

    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #50168
    Reviewed-By: Chengzhong Wu <[email protected]>
    mhdawson authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d62e812 View commit details
    Browse the repository at this point in the history
  30. test: v8: Add test-linux-perf-logger test suite

    PR-URL: #50352
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    lukealbao authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    ab9cad8 View commit details
    Browse the repository at this point in the history
  31. fs,url: move FileURLToPath to node_url

    PR-URL: #50090
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    anonrig authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4345ee2 View commit details
    Browse the repository at this point in the history
  32. fs,url: refactor FileURLToPath method

    PR-URL: #50090
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    anonrig authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    b4db32e View commit details
    Browse the repository at this point in the history
  33. fs,url: move FromNamespacedPath to node_url

    PR-URL: #50090
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    anonrig authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    67cbe1b View commit details
    Browse the repository at this point in the history
  34. fs: add stacktrace to fs/promises

    Sync functions in fs throwed an error with a stacktrace which is helpful
    for debugging. But functions in fs/promises throwed an error without
    a stacktrace. This commit adds stacktraces by calling
    Error.captureStacktrace and re-throwing the error.
    
    Refs: #34817
    PR-URL: #49849
    Fixes: #50160
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    sapphi-red authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    7e15111 View commit details
    Browse the repository at this point in the history
  35. stream: avoid calls to listenerCount

    PR-URL: #50357
    Reviewed-By: Raz Luvaton <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    893024c View commit details
    Browse the repository at this point in the history
  36. test: fix vm assertion actual and expected order

    PR-URL: #50371
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    legendecas authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    aa86c78 View commit details
    Browse the repository at this point in the history
  37. stream: improve from perf

    PR-URL: #50359
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    rluvaton authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    e20b272 View commit details
    Browse the repository at this point in the history
  38. test_runner: output errors of suites

    PR-URL: #50361
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    MoLow authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    913e4b9 View commit details
    Browse the repository at this point in the history
  39. doc: update notable changes in v21.1.0

    PR-URL: #50388
    Refs: nodejs/nodejs.org#6045
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    joyeecheung authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    0b11bf1 View commit details
    Browse the repository at this point in the history
  40. tools: update doc dependencies

    - [email protected]
    - [email protected]
    - [email protected]
    - [email protected]
    - [email protected]
    - [email protected]
    - [email protected]
    
    PR-URL: #49988
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    nodejs-github-bot authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    90c9dd3 View commit details
    Browse the repository at this point in the history
  41. Revert "tools: update doc dependencies"

    This reverts commit 6431c65.
    
    PR-URL: #50414
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    richardlau authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    92d6403 View commit details
    Browse the repository at this point in the history
  42. doc: fix typo in webstreams.md

    PR-URL: #50426
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Daeyeon Jeong <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    andrefs authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    43074ee View commit details
    Browse the repository at this point in the history
  43. permission: address coverity warning

    The latest version of coverity has suggestions on how
    to improve formance. Address one of these suggestions.
    
    Signed-off-by: Michael Dawson <[email protected]>
    PR-URL: #50215
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    mhdawson authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    7c35055 View commit details
    Browse the repository at this point in the history
  44. test: fix crypto-dh error message for OpenSSL 3.x

    OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs
    cause. The error message in test-crypto-dh for the "empty secret" is
    now 'Supplied key is too small' instead of
    'error:02800080:Diffie-Hellman routines::invalid secret'.
    
    Error message change is test-only and uses the right error message for
    versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series.
    
    ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=0df40630850fb2740e6be6890bb905d3fc623b2d
    ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=5f69f5c65e483928c4b28ed16af6e5742929f1ee
    ref. https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363
    
    PR-URL: #50395
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    krk authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    bd5b61f View commit details
    Browse the repository at this point in the history
  45. src: readiterable entries may be empty

    fixup
    
    PR-URL: #50398
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    KhafraDev authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4eb74a2 View commit details
    Browse the repository at this point in the history
  46. lib: align console.table row to the left

    PR-URL: #50135
    Fixes: #50117
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    MrJithil authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    3615a61 View commit details
    Browse the repository at this point in the history
  47. stream: use bit fields for construct/destroy

    PR-URL: #50408
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    03c4ff7 View commit details
    Browse the repository at this point in the history
  48. meta: add web-standards as web api visibility owner

    PR-URL: #50418
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    legendecas authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d94010b View commit details
    Browse the repository at this point in the history
  49. deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1

    PR-URL: #50411
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    nodejs-github-bot authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a64217c View commit details
    Browse the repository at this point in the history
  50. deps: update archs files for openssl-3.0.12+quic1

    PR-URL: #50411
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    nodejs-github-bot authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a90c6d6 View commit details
    Browse the repository at this point in the history
  51. stream: remove no longer relevant comment

    Refs: #50014
    PR-URL: #50446
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    ronag authored and targos committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    2c0d88e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. stream: pre-allocate _events

    PR-URL: #50428
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    ronag authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0116ae7 View commit details
    Browse the repository at this point in the history
  2. tools: avoid npm install in deps installation

    PR-URL: #50413
    Refs: #49747
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    marco-ippolito authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f759048 View commit details
    Browse the repository at this point in the history
  3. tools: remove unused version function

    PR-URL: #50390
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    UlisesGascon authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    aed5900 View commit details
    Browse the repository at this point in the history
  4. fs: update param in jsdoc for readdir

    PR-URL: #50448
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Jungku Lee authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    44f19ce View commit details
    Browse the repository at this point in the history
  5. src: hide node::credentials::HasOnly outside unit

    The function is not declared anywhere else and should not be visible
    outside the compilation unit.
    
    PR-URL: #50450
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    tniessen authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9f55dfc View commit details
    Browse the repository at this point in the history
  6. doc: remove duplicate word

    PR-URL: #50475
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Flarna authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    921e36e View commit details
    Browse the repository at this point in the history
  7. module: add application/json in accept header when fetching json module

    PR-URL: #50119
    Refs: #50116
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    marco-ippolito authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    667d245 View commit details
    Browse the repository at this point in the history
  8. lib: avoid memory allocation on nodeprecation flag

    PR-URL: #50231
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    H4ad authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6dabe7c View commit details
    Browse the repository at this point in the history
  9. tools: update lint-md-dependencies to [email protected] [email protected]

    PR-URL: #50461
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ec7005a View commit details
    Browse the repository at this point in the history
  10. deps: update undici to 5.27.0

    PR-URL: #50463
    Reviewed-By: Matthew Aitken <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0a793a2 View commit details
    Browse the repository at this point in the history
  11. deps: update acorn to 8.11.2

    PR-URL: #50460
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    28453ff View commit details
    Browse the repository at this point in the history
  12. tools: skip ruff on tools/gyp

    PR-URL: #50380
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9fc29c9 View commit details
    Browse the repository at this point in the history
  13. tools: update gyp-next to v0.16.1

    PR-URL: #50380
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    52e7b6d View commit details
    Browse the repository at this point in the history
  14. deps: patch V8 to 11.8.172.17

    Refs: v8/v8@11.8.172.15...11.8.172.17
    PR-URL: #50292
    Refs: v8/v8@11.8.172.15...11.8.172.16
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1e6922e View commit details
    Browse the repository at this point in the history
  15. meta: add [email protected] to mailmap

    PR-URL: #50491
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Ethan Arrowood authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c9e6e4e View commit details
    Browse the repository at this point in the history
  16. esm: add import.meta.dirname and import.meta.filename

    PR-URL: #48740
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    jsumners authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    eac9cc5 View commit details
    Browse the repository at this point in the history
  17. stream: fix Writable.destroy performance regression

    Ref: #50409
    PR-URL: #50478
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    ronag authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    360f5d9 View commit details
    Browse the repository at this point in the history
  18. wasi: document security sandboxing status

    PR-URL: #50396
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    guybedford authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2f86d50 View commit details
    Browse the repository at this point in the history
  19. vm: allow dynamic import with a referrer realm

    A referrer can be a Script Record, a Cyclic Module Record, or a Realm
    Record as defined in https://tc39.es/ecma262/#sec-HostLoadImportedModule.
    
    Add support for dynamic import calls with a realm as the referrer and
    allow specifying an `importModuleDynamically` callback in
    `vm.createContext`.
    
    PR-URL: #50360
    Refs: #49726
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    legendecas authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    773cfa5 View commit details
    Browse the repository at this point in the history
  20. module: execute --import sequentially

    PR-URL: #50474
    Fixes: #50427
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3606a0a View commit details
    Browse the repository at this point in the history
  21. deps: update zlib to 1.2.13.1-motley-dfc48fc

    PR-URL: #50456
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    57bfe53 View commit details
    Browse the repository at this point in the history
  22. tools: improve macOS notarization process output readability

    PR-URL: #50389
    Fixes: nodejs/build#3529
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    UlisesGascon authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    02dec64 View commit details
    Browse the repository at this point in the history
  23. doc: recommend supported Python versions

    Refs: #50209 (comment)
    PR-URL: #50407
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    lpinca authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    98cfa3a View commit details
    Browse the repository at this point in the history
  24. src: print more information in C++ assertions

    This patch:
    
    - Introduce an internal GetCurrentStackTrace() utility to get the
      current JavaScript stack trace with best effort.
    - Indent the assertion message so that is separated from the native
      stack trace for redability
    - Print the JS stack trace when it's available
    
    Previoiusly the abort message looks like this:
    
    ```
    out/Release/node[24458]: ../../src/node_file.cc:2008:void node::fs::Ope
    n(const FunctionCallbackInfo<v8::Value> &): Assertion `(argc) >= (3)' f
    ailed.
     1: 0x1043fb9a4 node::Abort() [node]
     2: 0x1043fb6e4 node::PrintCaughtException(v8::Isolate*, v8::Local<v8::
    Context>, v8::TryCatch const&) [node]
     3: 0x104407708 node::fs::Open(v8::FunctionCallbackInfo<v8::Value> cons
    t&) [node]
     4: 0x104611e74 v8::internal::MaybeHandle<v8::internal::Object> v8::int
    ernal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::
    Isolate*, v8::internal::Handle<v8::internal::HeapObject
    >, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::intern
    al::Handle<v8::internal::Object>, unsigned long*, int) [node
    ]
     5: 0x1046116c8 v8::internal::Builtin_HandleApiCall(int, unsigned long*
    , v8::internal::Isolate*) [node]
     6: 0x104e9cb24 Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit [node]
     7: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
     8: 0x104e1250c Builtins_JSEntryTrampoline [node]
     9: 0x104e121f4 Builtins_JSEntry [node]
    10: 0x1046ed54c v8::internal::(anonymous namespace)::Invoke(v8::interna
    l::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&)
    [node]
    11: 0x1046edb60 v8::internal::Execution::CallScript(v8::internal::Isola
    te*, v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Hand
    le<v8::internal::Object>, v8::internal::Handle<v8::in
    ternal::Object>) [node]
    12: 0x1045a9fa0 v8::Script::Run(v8::Local<v8::Context>, v8::Local<v8::D
    ata>) [node]
    13: 0x1043efb68 node::contextify::ContextifyScript::EvalMachine(v8::Loc
    al<v8::Context>, node::Environment*, long long, bool, bool, bool, v8::M
    icrotaskQueue*, v8::FunctionCallbackInfo<v8::Value> const&) [node
    ]
    14: 0x1043ef3e0 node::contextify::ContextifyScript::RunInContext(v8::Fu
    nctionCallbackInfo<v8::Value> const&) [node]
    15: 0x104611e74 v8::internal::MaybeHandle<v8::internal::Object> v8::int
    ernal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::
    Isolate*, v8::internal::Handle<v8::internal::HeapObject>
    , v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::interna
    l::Handle<v8::internal::Object>, unsigned long*, int) [node
    ]
    16: 0x1046116c8 v8::internal::Builtin_HandleApiCall(int, unsigned long*
    , v8::internal::Isolate*) [node]
    17: 0x104e9cb24 Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit [node]
    18: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
    19: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
    20: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
    21: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
    22: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
    23: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
    24: 0x104e143e4 Builtins_InterpreterEntryTrampoline [node]
    25: 0x104e1250c Builtins_JSEntryTrampoline [node]
    26: 0x104e121f4 Builtins_JSEntry [node]
    27: 0x1046ed54c v8::internal::(anonymous namespace)::Invoke(v8::interna
    l::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&)
    [node]
    28: 0x1046ecdc8 v8::internal::Execution::Call(v8::internal::Isolate*, v
    8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::int
    ernal::Object>, int, v8::internal::Handle<v
    8::internal::Object>*) [node]
    29: 0x1045be23c v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8
    ::Value>, int, v8::Local<v8::Value>*) [node]
    30: 0x1043df704 node::builtins::BuiltinLoader::CompileAndCall(v8::Local
    <v8::Context>, char const*, node::Realm*) [node]
    31: 0x10446f2d4 node::Realm::ExecuteBootstrapper(char const*) [node]
    32: 0x1043c3378 node::StartExecution(node::Environment*, std::__1::func
    tion<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&
    )>) [node]
    33: 0x10432dc28 node::LoadEnvironment(node::Environment*, std::__1::fun
    ction<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const
    &)>) [node]
    34: 0x10443d1f4 node::NodeMainInstance::Run(node::ExitCode*, node::Envi
    ronment*) [node]
    35: 0x10443cfd0 node::NodeMainInstance::Run() [node]
    36: 0x1043c5d18 node::Start(int, char**) [node]
    37: 0x19a027f28 start [/usr/lib/dyld]
    [1]    24458 abort      out/Release/node -p "process.binding('fs').open
    ()"
    ```
    
    Now it looks like this:
    
    ```
      #  out/Release/node[24856]: void node::fs::Open(const FunctionCallbac
    kInfo<v8::Value> &) at ../../src/node_file.cc:2008
      #  Assertion failed: (argc) >= (3)
    
    ----- Native stack trace -----
    
     1: 0x1001efe64 node::Abort() [node]
     2: 0x1001efba4 node::PrintCaughtException(v8::Isolate*, v8::Local<v8::
    Context>, v8::TryCatch const&) [node]
     3: 0x1001fb868 node::fs::Open(v8::FunctionCallbackInfo<v8::Value> cons
    t&) [node]
     4: 0x100405fd4 v8::internal::MaybeHandle<v8::internal::Object> v8::int
    ernal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::
    Isolate*, v8::internal::Handle<v8::internal::HeapObject
    >, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::intern
    al::Handle<v8::internal::Object>, unsigned long*, int) [node
    ]
     5: 0x100405828 v8::internal::Builtin_HandleApiCall(int, unsigned long*
    , v8::internal::Isolate*) [node]
     6: 0x100c90b24 Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit [node]
     7: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
     8: 0x100c0650c Builtins_JSEntryTrampoline [node]
     9: 0x100c061f4 Builtins_JSEntry [node]
    10: 0x1004e16ac v8::internal::(anonymous namespace)::Invoke(v8::interna
    l::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&)
    [node]
    11: 0x1004e1cc0 v8::internal::Execution::CallScript(v8::internal::Isola
    te*, v8::internal::Handle<v8::internal::JSFunction>, v8::internal::Hand
    le<v8::internal::Object>, v8::internal::Handle<v8::in
    ternal::Object>) [node]
    12: 0x10039e100 v8::Script::Run(v8::Local<v8::Context>, v8::Local<v8::D
    ata>) [node]
    13: 0x1001e4028 node::contextify::ContextifyScript::EvalMachine(v8::Loc
    al<v8::Context>, node::Environment*, long long, bool, bool, bool, v8::M
    icrotaskQueue*, v8::FunctionCallbackInfo<v8::Value> const&) [node
    ]
    14: 0x1001e38a0 node::contextify::ContextifyScript::RunInContext(v8::Fu
    nctionCallbackInfo<v8::Value> const&) [node]
    15: 0x100405fd4 v8::internal::MaybeHandle<v8::internal::Object> v8::int
    ernal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::
    Isolate*, v8::internal::Handle<v8::internal::HeapObject>
    , v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::interna
    l::Handle<v8::internal::Object>, unsigned long*, int) [node
    ]
    16: 0x100405828 v8::internal::Builtin_HandleApiCall(int, unsigned long*
    , v8::internal::Isolate*) [node]
    17: 0x100c90b24 Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit [node]
    18: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
    19: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
    20: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
    21: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
    22: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
    23: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
    24: 0x100c083e4 Builtins_InterpreterEntryTrampoline [node]
    25: 0x100c0650c Builtins_JSEntryTrampoline [node]
    26: 0x100c061f4 Builtins_JSEntry [node]
    27: 0x1004e16ac v8::internal::(anonymous namespace)::Invoke(v8::interna
    l::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&)
    [node]
    28: 0x1004e0f28 v8::internal::Execution::Call(v8::internal::Isolate*, v
    8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::int
    ernal::Object>, int, v8::internal::Handle<v
    8::internal::Object>*) [node]
    29: 0x1003b239c v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8
    ::Value>, int, v8::Local<v8::Value>*) [node]
    30: 0x1001d3bc4 node::builtins::BuiltinLoader::CompileAndCall(v8::Local
    <v8::Context>, char const*, node::Realm*) [node]
    31: 0x100263434 node::Realm::ExecuteBootstrapper(char const*) [node]
    32: 0x1001b7838 node::StartExecution(node::Environment*, std::__1::func
    tion<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&
    )>) [node]
    33: 0x100121c28 node::LoadEnvironment(node::Environment*, std::__1::fun
    ction<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const
    &)>) [node]
    34: 0x100231354 node::NodeMainInstance::Run(node::ExitCode*, node::Envi
    ronment*) [node]
    35: 0x100231130 node::NodeMainInstance::Run() [node]
    36: 0x1001ba1d8 node::Start(int, char**) [node]
    37: 0x19a027f28 start [/usr/lib/dyld]
    
    ----- JavaScript stack trace -----
    
    1: [eval]:1:23
    2: runScriptInThisContext (node:internal/vm:144:10)
    3: node:internal/process/execution:109:14
    4: [eval]-wrapper:6:24
    5: runScript (node:internal/process/execution:92:62)
    6: evalScript (node:internal/process/execution:123:10)
    7: node:internal/main/eval_string:51:3
    
    [1]    24856 abort      out/Release/node -p "process.binding('fs').open
    ()"
    ```
    
    PR-URL: #50242
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    joyeecheung authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6e20e08 View commit details
    Browse the repository at this point in the history
  25. doc: underline links

    The current use of color only to differentiate links fails WCAG A
    accessibility standards.
    
    Possible solutions are:
    
    1. Using a text indicator to show that the text is a link.
    2. Using additional cues (such as underlining).
    3. Providing color contrast of 3:1 or greater with surrounding text
       (not the background--the adjacent text!) along with visual cues
       on hover.
    
    The solution here implements the second option.
    
    Ref: https://www.w3.org/WAI/WCAG21/Understanding/use-of-color.html
    Ref: https://www.w3.org/WAI/WCAG21/Techniques/failures/F73
    Ref: https://www.w3.org/WAI/WCAG21/Techniques/general/G182
    PR-URL: #50481
    Refs: https://www.w3.org/WAI/WCAG21/Understanding/use-of-color.html
    Refs: https://www.w3.org/WAI/WCAG21/Techniques/failures/F73
    Refs: https://www.w3.org/WAI/WCAG21/Techniques/general/G182
    Reviewed-By: Claudio Wunder <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    886fc48 View commit details
    Browse the repository at this point in the history
  26. deps: update nghttp2 to 1.58.0

    PR-URL: #50441
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    189e5e5 View commit details
    Browse the repository at this point in the history
  27. test: fix timeout of test-cpu-prof-dir-worker.js in LoongArch devices

    PR-URL: #50363
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    shipujin authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2b6d283 View commit details
    Browse the repository at this point in the history
  28. test: replace forEach with for...of in test-fs-realpath-buffer-encoding

    PR-URL: #49804
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Yongsheng Zhang <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    niyashiyas authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    d24de12 View commit details
    Browse the repository at this point in the history
  29. test: fix testsuite against zlib version 1.3

    In the past, zlib versions had major.minor.micro formats, but with 1.3
    this has been changed.
    
    Change the test code to accept one, two, or three elements past the
    major version.
    
    PR-URL: #50364
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    DimStar77 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f70a2dd View commit details
    Browse the repository at this point in the history
  30. lib: use primordials for navigator.userAgent

    PR-URL: #50467
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Ethan Arrowood <[email protected]>
    Uzlopak authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c9bd0c5 View commit details
    Browse the repository at this point in the history
  31. test: replace forEach() with for...of in test-trace-events-http

    PR-URL: #49795
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    chandrakhishma authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f40435d View commit details
    Browse the repository at this point in the history
  32. test: replace forEach() with for...of

    Replace `forEach()` with `for...of` in in test-dgram-socket-buffer-size.
    
    PR-URL: #49794
    Reviewed-By: Luigi Pinca <[email protected]>
    Ram1607 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    90833a8 View commit details
    Browse the repository at this point in the history
  33. lib: add navigator.platform

    PR-URL: #50385
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Uzlopak authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f932f4c View commit details
    Browse the repository at this point in the history
  34. tools: update lint-md-dependencies to [email protected]

    PR-URL: #50496
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c0206bf View commit details
    Browse the repository at this point in the history
  35. deps: upgrade npm to 10.2.3

    PR-URL: #50531
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    npm-cli-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    93e3cc3 View commit details
    Browse the repository at this point in the history
  36. test: report error wpt test results

    When a wpt test file is exited for uncaught error, its result should be
    recorded in the `wptreport.json` and uploaded to wpt.fyi.
    
    For instance, `html/webappapis/timers/evil-spec-example.any.js` is
    exited for uncaught error in Node.js but it shows as "MISSING" at
    https://wpt.fyi/results/html/webappapis/timers?label=master&label=experimental&product=chrome&product=node.js&aligned.
    
    PR-URL: #50429
    Reviewed-By: Filip Skokan <[email protected]>
    legendecas authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7e3eb02 View commit details
    Browse the repository at this point in the history
  37. test: recognize wpt completion error

    PR-URL: #50429
    Reviewed-By: Filip Skokan <[email protected]>
    legendecas authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ee75110 View commit details
    Browse the repository at this point in the history
  38. test: improve UV_THREADPOOL_SIZE tests on .env

    PR-URL: #49213
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    anonrig authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8487cac View commit details
    Browse the repository at this point in the history
  39. test: skip test-diagnostics-channel-memory-leak.js

    There is currently no reliable way to detect this leak because:
    
    1. We cannot reliably get a reference to the channel from the
      API to detect finalization without creating another strong reference.
    2. This test does gc() and then checks memory usage - however the
      use of gc() disables code aging which can actually lead to increased
      memory usage overall, as it is not intended to be used to lower
      memory usage in the first place.
    3. The implementation of diagnostics channels relies on ephemeron gc
      which is inefficient, it's not reliable to use the typical "create
      a lot of objects and see if it crashes" trick to check leaks.
    
    Skip the test for now until we find a way to test it reliably.
    
    To avoid flakiness in the CI, it's better to remove an unreliable
    test altogether.
    
    PR-URL: #50327
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Stephen Belanger <[email protected]>
    joyeecheung authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    de46a34 View commit details
    Browse the repository at this point in the history
  40. meta: bump actions/checkout from 4.1.0 to 4.1.1

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@8ade135...b4ffde6)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50511
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    dependabot[bot] authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8403030 View commit details
    Browse the repository at this point in the history
  41. meta: bump actions/setup-node from 3.8.1 to 4.0.0

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.1 to 4.0.0.
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@5e21ff4...8f152de)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-node
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50514
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    dependabot[bot] authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ff9b3bd View commit details
    Browse the repository at this point in the history
  42. lib: add navigator.language & navigator.languages

    PR-URL: #50303
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Uzlopak authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    03c730b View commit details
    Browse the repository at this point in the history
  43. tools: improve update acorn-walk script

    PR-URL: #50473
    Refs: nodejs/security-wg#1037
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    marco-ippolito authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    aa8feea View commit details
    Browse the repository at this point in the history
  44. src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace()

    It was using Isolate::GetCurrent() which DCHECK on nullptr, even
    though what we wanted was to return early if it is nullptr.
    
    PR-URL: #50518
    Refs: #50242
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Juan José Arboleda <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    joyeecheung authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b740324 View commit details
    Browse the repository at this point in the history
  45. tools: compare ICU checksums before file changes

    Otherwise we end up with an bad update PR when checksums don't match.
    
    Refs: #50495
    PR-URL: #50522
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    257e220 View commit details
    Browse the repository at this point in the history
  46. build: support Python 3.12

    PR-URL: #50209
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Christian Clauss <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    shipujin authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    642c057 View commit details
    Browse the repository at this point in the history
  47. deps: V8: cherry-pick 13192d6e10fa

    Original commit message:
    
        [riscv][tagged-ptr] Convert more Objects to Tagged<>
    
        Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80
    
        Bug: v8:12710
    
        Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
        Reviewed-by: Ji Qiu <[email protected]>
        Commit-Queue: Ji Qiu <[email protected]>
        Auto-Submit: Yahan Lu <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#89780}
    
    Refs: v8/v8@13192d6
    PR-URL: #50552
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    kxxt authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    78b3432 View commit details
    Browse the repository at this point in the history
  48. doc: update to align console.table row to the left

    PR-URL: #50553
    Refs: #50135
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Deokjin Kim <[email protected]>
    Jungku Lee authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1668798 View commit details
    Browse the repository at this point in the history
  49. tools: update lint-md-dependencies to [email protected]

    PR-URL: #50556
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f5e1c95 View commit details
    Browse the repository at this point in the history
  50. tools: update eslint to 8.53.0

    PR-URL: #50559
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    253e206 View commit details
    Browse the repository at this point in the history
  51. doc: correct attribution in v20.6.0 changelog

    PR-URL: #50564
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Claudio Wunder <[email protected]>
    JakobJingleheimer authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    479c1ea View commit details
    Browse the repository at this point in the history
  52. deps: update corepack to 0.23.0

    PR-URL: #50563
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f70a59f View commit details
    Browse the repository at this point in the history
  53. test: replace forEach() with for ... of loop in test-global.js

    PR-URL: #49772
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    shizuka1308 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7c7be51 View commit details
    Browse the repository at this point in the history
  54. doc: update pm documentation to include resource

    PR-URL: #50601
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    Ranieri93 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4cbe44e View commit details
    Browse the repository at this point in the history
  55. test: add WPT report test duration

    PR-URL: #50574
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    panva authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6ed8fbf View commit details
    Browse the repository at this point in the history
  56. test_runner, cli: add --test-timeout flag

    PR-URL: #50443
    Fixes: #50431
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Raz Luvaton <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    shubham9411 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    05e8b6e View commit details
    Browse the repository at this point in the history
  57. test_runner: replace forEach with for of

    PR-URL: #50595
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    tomhaddad authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ae4a7ba View commit details
    Browse the repository at this point in the history
  58. doc: add missing description of argument in subtle.encrypt

    Description of third argument(data) in subtle.encrypt is missed,
    so add it.
    
    PR-URL: #50578
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    deokjinkim authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a656bf2 View commit details
    Browse the repository at this point in the history
  59. meta: add crypto as crypto and webcrypto docs owner

    PR-URL: #50579
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    panva authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    85a527e View commit details
    Browse the repository at this point in the history
  60. doc: fix typo in fs.md

    PR-URL: #50570
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    3fuyang authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8be0efd View commit details
    Browse the repository at this point in the history
  61. lib: add --no-experimental-global-navigator CLI flag

    PR-URL: #50562
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Ethan Arrowood <[email protected]>
    aduh95 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6dbb280 View commit details
    Browse the repository at this point in the history
  62. test: relax version check with shared OpenSSL

    Relax the OpenSSL version check when Node.js is built with the
    `--shared-openssl` option. Verify only that `process.versions.openssl`
    is truthy.
    
    Fixes: #43078
    PR-URL: #50505
    Reviewed-By: Richard Lau <[email protected]>
    lpinca authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    931e1e7 View commit details
    Browse the repository at this point in the history
  63. build: fix build with Python 3.12

    Replace `distutils.version.StrictVersion` with
    `packaging.version.Version`.
    
    Refs: #50209 (comment)
    PR-URL: #50582
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    lpinca authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    22eb025 View commit details
    Browse the repository at this point in the history
  64. benchmark: change iterations in benchmark/es/string-concatenations.js

    Increase the number of iterations from `1e3` to `1e6`
    to avoid the test performance gap caused by inactive
    V8 optimization caused by too few iterations.
    
    Fixes: #50571
    PR-URL: #50585
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Septa2112 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    065d884 View commit details
    Browse the repository at this point in the history
  65. stream: add support for deflate-raw format to webstreams compression

    this change makes `deflate-raw` a valid parameter for both
    CompressionStream and DecompressionStream constructors
    
    it makes node's implementation consistent with what modern browsers
    support and what specification calls for
    
    see: https://wicg.github.io/compression/#compression-stream
    PR-URL: #50097
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    pirxpilot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    91f37d1 View commit details
    Browse the repository at this point in the history
  66. esm: bypass CJS loader in default load under --default-type=module

    This allows user to opt-out from using the monkey-patchable CJS loader,
    even to load CJS modules.
    
    PR-URL: #50004
    Reviewed-By: Geoffrey Booth <[email protected]>
    aduh95 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    09c02ed View commit details
    Browse the repository at this point in the history
  67. test: replace forEach with for [...] of

    PR-URL: #50615
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    dygabo authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    52b517f View commit details
    Browse the repository at this point in the history
  68. buffer: improve Buffer.equals performance

    PR-URL: #50621
    Refs: #50620
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    kylo5aby authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3bedaf9 View commit details
    Browse the repository at this point in the history
  69. test: replace forEach with for of

    PR-URL: #49785
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    CorrWu authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    1d52a57 View commit details
    Browse the repository at this point in the history
  70. test: replace forEach with for of

    PR-URL: #50597
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    jabali2004 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2eeda3f View commit details
    Browse the repository at this point in the history
  71. lib: make event static properties non writable and configurable

    The idl definition for Event makes the properties constant
    this means that they shouldn't be configurable and writable.
    However, they were, and this commit fixes that.
    
    Fixes: #50417
    PR-URL: #50425
    Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
    Reviewed-By: Matthew Aitken <[email protected]>
    BenzeneAlcohol authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5fa40be View commit details
    Browse the repository at this point in the history
  72. tls: use validateFunction for options.SNICallback

    If user uses invalid type for `options.SNICallback` in
    TLSSocket(), it's not internal issue of Node.js. So
    validateFunction() is more proper than assert().
    
    PR-URL: #50530
    Reviewed-By: Luigi Pinca <[email protected]>
    deokjinkim authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b71c8c4 View commit details
    Browse the repository at this point in the history
  73. test: remove unused file

    This removes a source file that got re-added via a rebase.
    It seems somewhere around change set
    178dff2
    `entry_point.c` was removed, and rebase
    0b6e16f
    added it back. The review of #48740
    overlooked this and the file got re-committed.
    
    PR-URL: #50528
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Vladimir Morozov <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    jsumners authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2fdcf5c View commit details
    Browse the repository at this point in the history
  74. test: replace forEach with for of

    PR-URL: #50602
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    john-mcinall authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    864cd32 View commit details
    Browse the repository at this point in the history
  75. meta: bump actions/setup-python from 4.7.0 to 4.7.1

    Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.0 to 4.7.1.
    - [Release notes](https://github.com/actions/setup-python/releases)
    - [Commits](actions/setup-python@61a6322...65d7f2d)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-python
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50510
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    dependabot[bot] authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    12e54e3 View commit details
    Browse the repository at this point in the history
  76. test_runner: pass abortSignal to test files

    PR-URL: #50630
    Fixes: #50583
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Chemi Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    MoLow authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    01bed64 View commit details
    Browse the repository at this point in the history
  77. deps: update base64 to 0.5.1

    PR-URL: #50629
    Fixes: #50561
    Fixes: #45091
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    nodejs-github-bot authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5073a3e View commit details
    Browse the repository at this point in the history
  78. build: add GN build files

    PR-URL: #47637
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    zcbenz authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b9f3613 View commit details
    Browse the repository at this point in the history
  79. doc: add MrJithil to collaborators

    Fixes: #50533
    PR-URL: #50666
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    MrJithil authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e25c65e View commit details
    Browse the repository at this point in the history
  80. test: replace forEach() with for ... of in test-http2-single-headers.js

    PR-URL: #50606
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    spiritualized authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bc92be4 View commit details
    Browse the repository at this point in the history
  81. lib: fix assert shows diff messages in ESM and CJS

    This PR addresses an issue which was caused by the design in
    the ESM loader.
    The ESM loader was modifying the file path and replacing the 'file'
    property with the file proto in the stack trace.
    This, in turn, led to unhandled exceptions when the assert module
    attempted to open the file to display erroneous code.
    The changes in this PR resolve this issue by handling the file path
    correctly, ensuring that the remaining message formatting code can
    execute as expected.
    
    PR-URL: #50634
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    MrJithil authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    363bc46 View commit details
    Browse the repository at this point in the history
  82. meta: fix spacing in collaborator list

    PR-URL: #50641
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    49cce76 View commit details
    Browse the repository at this point in the history
  83. test: replace forEach() with for ... of in test-readline-keys.js

    PR-URL: #50604
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    WillLiang918 authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e978fd4 View commit details
    Browse the repository at this point in the history
  84. test: replace forEach() with for .. of

    PR-URL: #50605
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bliakher authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    b701567 View commit details
    Browse the repository at this point in the history
  85. lib: remove deprecated string methods

    PR-URL: #50592
    Reviewed-By: Marco Ippolito <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    MrJithil authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ed293fc View commit details
    Browse the repository at this point in the history
  86. meta: bump ossf/scorecard-action from 2.2.0 to 2.3.1

    Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.1.
    - [Release notes](https://github.com/ossf/scorecard-action/releases)
    - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
    - [Commits](ossf/scorecard-action@08b4669...0864cf1)
    
    ---
    updated-dependencies:
    - dependency-name: ossf/scorecard-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50509
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    dependabot[bot] authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4bf9cff View commit details
    Browse the repository at this point in the history
  87. meta: bump step-security/harden-runner from 2.5.1 to 2.6.0

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.5.1 to 2.6.0.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@8ca2b8b...1b05615)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50512
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    dependabot[bot] authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4e83036 View commit details
    Browse the repository at this point in the history
  88. meta: bump github/codeql-action from 2.21.9 to 2.22.5

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.9 to 2.22.5.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@ddccb87...74483a3)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    PR-URL: #50513
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    dependabot[bot] authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    dedfb5a View commit details
    Browse the repository at this point in the history
  89. errors: improve hideStackFrames

    PR-URL: #49990
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Uzlopak authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    14e3675 View commit details
    Browse the repository at this point in the history
  90. test: use destructuring for accessing setting values

    PR-URL: #50609
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    yedlosh authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8be718a View commit details
    Browse the repository at this point in the history
  91. tools: add macOS notarization stapler

    PR-URL: #50625
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    UlisesGascon authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5fcd67a View commit details
    Browse the repository at this point in the history
  92. meta: add web-standards as WPTs owner

    PR-URL: #50636
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Debadree Chatterjee <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    panva authored and targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9e7131f View commit details
    Browse the repository at this point in the history
  93. 2023-11-14, Version 21.2.0 (Current)

    Notable changes:
    
    doc:
      * add MrJithil to collaborators (Jithil P Ponnan) #50666
      * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
    esm:
      * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
    fs:
      * add stacktrace to fs/promises (翠 / green) #49849
    lib:
      * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
      * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
      * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
    stream:
      * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
      * use Array for Readable buffer (Robert Nagy) #50341
      * optimize creation (Robert Nagy) #50337
    test_runner:
      * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
      * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
    test_runner, cli:
      * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443
    
    PR-URL: #50681
    targos committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    13b266f View commit details
    Browse the repository at this point in the history