Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick 13192d6e10fa #50551

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick 13192d6e10fa #50551

wants to merge 1 commit into from

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Nov 4, 2023

Node.js 21.1.0 can't be built on riscv64 without this v8 commit.

See compilation errors in this build log: https://paste.rs/h6xxt

Original commit message:

[riscv][tagged-ptr] Convert more Objects to Tagged<>

Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

Bug: v8:12710

Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
Reviewed-by: Ji Qiu <[email protected]>
Commit-Queue: Ji Qiu <[email protected]>
Auto-Submit: Yahan Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6

@kxxt
deps: V8: cherry-pick 13192d6e10fa
4dcdef8 
Original commit message:

    [riscv][tagged-ptr] Convert more Objects to Tagged<>

    Port commit 064b9a7903b793734b6c03a86ee53a2dc85f0f80

    Bug: v8:12710

    Change-Id: If076ca5cd9e9d175c20fc3611e03d39c0260404d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4837830
    Reviewed-by: Ji Qiu <[email protected]>
    Commit-Queue: Ji Qiu <[email protected]>
    Auto-Submit: Yahan Lu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#89780}

Refs: v8/v8@13192d6
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v21.x v8 engine Issues and PRs related to the V8 dependency. labels Nov 4, 2023
@richardlau
Copy link
Member

Is this needed on main? If so the PR should target that and we'll cherry-pick/backport to v21.x-staging.

@kxxt
Copy link
Contributor Author

kxxt commented Nov 4, 2023

Is this needed on main? If so the PR should target that and we'll cherry-pick/backport to v21.x-staging.

Yes. It is needed on main as well. I will open a PR to main. Should I close this one?

@kxxt
Copy link
Contributor Author

kxxt commented Nov 4, 2023

I have opened #50552

@kxxt kxxt closed this Nov 4, 2023
@kxxt kxxt deleted the fix-node21-compilation-riscv branch November 4, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kxxt @nodejs-github-bot @richardlau