Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: compare ICU checksums before file changes #50522

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

targos
Copy link
Member

@targos targos commented Nov 2, 2023

Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495

Otherwise we end up with an bad update PR when checksums don't match.

Refs: nodejs#50495
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 2, 2023
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit cde3296 into nodejs:main Nov 6, 2023
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cde3296

@targos targos deleted the tools-icu-checksum branch November 6, 2023 11:23
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
Otherwise we end up with an bad update PR when checksums don't match.

Refs: nodejs#50495
PR-URL: nodejs#50522
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos added a commit that referenced this pull request Nov 11, 2023
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos added a commit that referenced this pull request Nov 14, 2023
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this but 💯 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants