Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: do not call getSource when format is commonjs #50465

Merged
merged 6 commits into from
Nov 29, 2023
Merged

esm: do not call getSource when format is commonjs #50465

merged 6 commits into from
Nov 29, 2023

Commits on Nov 28, 2023

  1. esm: do not call getSource when format is commonjs 

    Ensure that `defaultLoad` does not uselessly access the file system to
get the source of modules that are known to be in CommonJS format.

This allows CommonJS imports to resolve in the current phase of the
event loop.

Refs: eslint/eslint#17683
    @fasttime
    fasttime committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    fa1a8d2 View commit details
    Browse the repository at this point in the history

  2. fix lint problems

    @fasttime
    fasttime committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7c420ad View commit details
    Browse the repository at this point in the history

  3. use fixtures in tests

    @fasttime
    fasttime committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6dcb668 View commit details
    Browse the repository at this point in the history

  4. add test for loader-provided source

    @fasttime
    fasttime committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d21699e View commit details
    Browse the repository at this point in the history

  5. use absolute file URL in test

    @fasttime
    fasttime committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    80d1ef1 View commit details
    Browse the repository at this point in the history

  6. use base URL in test

    @fasttime
    fasttime committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    45c9a4a View commit details
    Browse the repository at this point in the history