Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update nghttp3 to 1.0.0 #50462

Closed
wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of nghttp3 to 1.0.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Oct 29, 2023
@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@aduh95
Copy link
Contributor

aduh95 commented Oct 30, 2023

This fails to build on several platforms

Undefined			first referenced
 symbol  			    in file
nghttp3_unreachable_fail            /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/ngtcp2/libnghttp3.a(nghttp3_conn.o)
ld: fatal: symbol referencing errors. No output written to /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/cctest
collect2: error: ld returned 1 exit status
make[2]: *** [cctest.target.mk:329: /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/cctest] Error 1
make[2]: *** Waiting for unfinished jobs....
Undefined			first referenced
 symbol  			    in file
nghttp3_unreachable_fail            /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/obj.target/deps/ngtcp2/libnghttp3.a(nghttp3_conn.o)
ld: fatal: symbol referencing errors. No output written to /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/embedtest
collect2: error: ld returned 1 exit status

@jasnell
Copy link
Member

jasnell commented Nov 11, 2023

The automated updater misses new files / changed files. This will need to be done manually. I'll take care of it manually soon as I'll already be working on this bit. It's possible there are api changes that need to be accounted for.

@jasnell jasnell closed this Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants