Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use BignumPointer and use BN_clear_free #50454

Closed
wants to merge 1 commit into from
Closed

src: use BignumPointer and use BN_clear_free #50454

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 28, 2023

No description provided.

@jasnell jasnell added crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 28, 2023
@jasnell jasnell force-pushed the crypto-use-bignum-pointer branch from 0b1c533 to bb52365 Compare October 28, 2023 20:20
@jasnell jasnell force-pushed the crypto-use-bignum-pointer branch from bb52365 to b55c6dd Compare November 12, 2023 17:04
@jasnell jasnell requested a review from tniessen November 12, 2023 17:06
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Open
26 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the crypto-use-bignum-pointer branch from b55c6dd to 7dd07c1 Compare December 22, 2023 02:17
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56451/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/56456/ 💛

@jasnell jasnell force-pushed the crypto-use-bignum-pointer branch from 7dd07c1 to f7ff63e Compare December 22, 2023 04:47
jasnell added a commit that referenced this pull request Dec 22, 2023
@jasnell
src: use BignumPointer and use BN_clear_free
1523650 
PR-URL: #50454
Reviewed-By: Joyee Cheung <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Dec 22, 2023

Landed in 1523650

@jasnell jasnell closed this Dec 22, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell @RafaelGSS
src: use BignumPointer and use BN_clear_free
96d64ed 
PR-URL: #50454
Reviewed-By: Joyee Cheung <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@jasnell @richardlau
src: use BignumPointer and use BN_clear_free
9b25268 
PR-URL: #50454
Reviewed-By: Joyee Cheung <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen Awaiting requested review from tniessen

@addaleax addaleax Awaiting requested review from addaleax

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @tniessen @joyeecheung