Revert "tools: update doc dependencies" #50414
Conversation
This reverts commit 6431c65.
|
Review requested:
|
nodejs-github-bot
added
doc
github-actions
bot
removed
the
request-ci
richardlau
added
the
author ready
joyeecheung
added
the
fast-track
|
Separated from this (which I think should land ASAP), I wonder if we should just skip doc generation/tests in without-intl builds |
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
That was a suggestion in #35942 (comment), which references #41091 which I'm now confused over as it suggests we shouldn't be attempting to generate docs without intl available? Maybe either something was missed there or we've subsequently changed something in how the docs are generated that means they're no longer being skipped? 🤔 |
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 67b1383 |
Do we have other Node.js installations available in the system? #41091 checks the availability of intl using whatever Node.js binary available in the system ( |
|
hmm, I think this is caused by a missing dependency check in |
|
So it seems the cause is that:
Not sure how this can be addressed easily. I think we do still want to test the addons in addons.md in without-intl builds. Perhaps we can just use some dumb marker in addons.md to denote where the code examples are and write a custom parser instead of using remark. |
This reverts commit 6431c65. PR-URL: nodejs#50414 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This reverts commit 6431c65. PR-URL: #50414 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This reverts commit 6431c65. PR-URL: #50414 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This reverts commit 6431c65.
Refs: #49988 (comment)
This is a quick revert to fix the without-intl builds on the Jenkins CI. If someone else has a better fix that can be landed quickly, feel free to close this one.