Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add more cases to Readable.from #50351

Merged

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Oct 23, 2023

I'm planning to improve the from perf...

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. stream Issues and PRs related to the stream subsystem. labels Oct 23, 2023
@rluvaton rluvaton added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 23, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @rluvaton. Please 👍 to approve.

@rluvaton rluvaton force-pushed the add-more-cases-to-readable-from branch from 63aa6aa to 2fbbaed Compare October 23, 2023 22:10
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0fb5123 into nodejs:main Oct 24, 2023
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0fb5123

@rluvaton rluvaton deleted the add-more-cases-to-readable-from branch October 24, 2023 08:25
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants