stream: readable use bitmap accessors #50350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ronag
commented
Oct 23, 2023
ronag
commented
|
Review requested:
|
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 23, 2023
ronag
force-pushed
the
readable-bitmap
branch
from
4b160a9
to
87024e5
Compare
rluvaton
added
stream
benjamingr
approved these changes
Oct 23, 2023
rluvaton
approved these changes
Oct 23, 2023
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 23, 2023
ronag
force-pushed
the
readable-bitmap
branch
from
87024e5
to
d6e11dc
Compare
github-actions
bot
removed
the
request-ci
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 24, 2023
ronag
force-pushed
the
readable-bitmap
branch
from
d6e11dc
to
3544359
Compare
ronag
changed the title
ronag
force-pushed
the
readable-bitmap
branch
from
3544359
to
b9248c9
Compare
ronag
added
the
author ready
ronag
added
the
commit-queue
16 tasks
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50350 ✔ Done loading data for nodejs/node/pull/50350 ----------------------------------- PR info ------------------------------------ Title stream: readable use bitmap accessors (#50350) Author Robert Nagy (@ronag) Branch ronag:readable-bitmap -> nodejs:main Labels stream, performance, author ready, needs-ci, needs-benchmark-ci Commits 1 - stream: readable use bitmap accessors Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50350 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Raz Luvaton ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50350 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Raz Luvaton -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: readable use bitmap accessors ℹ This PR was created on Mon, 23 Oct 2023 21:04:28 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693524231 ✔ - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693525520 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-24T13:57:48Z: https://ci.nodejs.org/job/node-test-pull-request/55189/ - Querying data for job/node-test-pull-request/55189/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6646200515 |
rluvaton
approved these changes
Oct 25, 2023
rluvaton
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 31e0759 |
This was referenced Oct 26, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50350 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50350 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50350 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.