Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: Fix mock timer promisified setInterval return value #50331

Merged
merged 3 commits into from
Oct 25, 2023
Merged

test_runner: Fix mock timer promisified setInterval return value #50331

merged 3 commits into from
Oct 25, 2023

Commits on Oct 23, 2023

  1. test_runner: test return value of mocked promisified timers

    @mika-fischer
    mika-fischer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ea2a31e View commit details
    Browse the repository at this point in the history

  2. test_runner: fix mock timer promisified setInterval return value 

    promisified setInterval can be passed a value that is returned by the
async iterable. The mocked promisified setInterval used this value for
its own purposes. This brings the mocked version in line with the
original.

Fixes: nodejs#50307
    @mika-fischer
    mika-fischer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    88e13a7 View commit details
    Browse the repository at this point in the history

  3. test_runner: fix mock timer setInterval tests 

    Some tests relied on the custom return value and were broken by the
change to always return the value provided by the caller.
    @mika-fischer
    mika-fischer committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    06d8b9d View commit details
    Browse the repository at this point in the history