Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: fix order of setting cipher before setting cert and key #50186

Closed
wants to merge 5 commits into from
Closed

tls: fix order of setting cipher before setting cert and key #50186

wants to merge 5 commits into from

Commits on Oct 16, 2023

  1. tls: fix order of setting cipher before setting cert and key 

    Set the cipher list and cipher suite before anything else
because @SECLEVEL=<n> changes the security level and
that affects subsequent operations.

Fixes: nodejs#36655
nodejs#49549

Refs: https://github.com/orgs/nodejs/discussions/49634
https://github.com/orgs/nodejs/discussions/46545

https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_security_level.html
    @kumarrishav
    kumarrishav committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    52ca521 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge branch 'nodejs:main' into main

    @kumarrishav
    kumarrishav authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    958bd71 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Merge branch 'nodejs:main' into main

    @kumarrishav
    kumarrishav authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9e89099 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'nodejs:main' into main

    @kumarrishav
    kumarrishav authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    39c3ee1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'nodejs:main' into main

    @kumarrishav
    kumarrishav authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    1d66ab4 View commit details
    Browse the repository at this point in the history