perf_hooks: reduce overhead of createHistogram #50074

H4ad · 2023-10-07T00:57:24Z

Continuing the work started on nodejs/performance#109

                                       confidence improvement accuracy (*)   (**)  (***)
perf_hooks/histogram-clone.js n=100000        ***    102.24 %       ±1.15% ±1.53% ±2.00%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

                                        confidence improvement accuracy (*)   (**)  (***)
perf_hooks/histogram-create.js n=100000        ***     30.19 %       ±0.50% ±0.66% ±0.87%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 1 comparisons, you can thus
expect the following amount of false-positive results:
  0.05 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.01 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

/cc @nodejs/performance

anonrig · 2023-10-07T01:03:46Z

lib/internal/histogram.js

@@ -318,26 +327,36 @@ class RecordableHistogram extends Histogram {
  }
 }

-function internalHistogram(handle) {
+function ClonedHistogram(handle) {


This ReflectConstruct can be removed as well

Yeah, but since it is not exposed directly I didn't think that was worth it, if not for spec compliance, this code could be removed (I think).

Qard

LGTM, with a minor nit.

lib/internal/histogram.js

mcollina

lgtm

H4ad · 2023-10-12T13:35:59Z

Someone can add author ready?

nodejs-github-bot · 2023-10-15T15:52:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54827/

H4ad · 2023-10-18T00:28:14Z

I added another commit to try address https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1804-64/54333/console, I think now both functions are optimized, it is causing an issue with v8 dead code.

benchmark/perf_hooks/histogram.js

nodejs-github-bot · 2023-10-19T11:31:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54996/

nodejs-github-bot · 2023-10-20T23:29:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55071/

nodejs-github-bot · 2023-10-21T12:24:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55087/

PR-URL: #50074 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

RafaelGSS · 2023-10-25T03:21:48Z

@H4ad Why this was landed with rebase? It doesn't contain atomic/independent commits that pass the tests according to our contribution guidelines. It also includes a fixup commit to the main queue. Please, use commit-queue-squash for these situations.

H4ad · 2023-10-25T03:41:07Z

My idea was to ship both commits since I initially thought they should be independent, but thinking more about the reason why I had the commit of test: avoid... was due to the optimization made by the previous commit that caused a test to be flaky, maybe all those commits were better to be landed in just one commit.

But making all the tests pass for each commit that will land in the same PR is something I misread from the guidelines, in case I need to do that, how do I ensure all the tests will pass for previous commits, should I call the job request-ci for each commit?

RafaelGSS · 2023-10-25T16:44:41Z

Usually, you guarantee by running the tests on your machine. When you add the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. each the commit shouldn't depend on a subsequent commit otherwise you'll make future git bisect very hard and potential conflicts resolutions when creating the release proposal difficult too - you can check the releases.md how we use git cherry-pick.

Reference: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-squashing

aduh95 · 2023-10-25T18:46:37Z

I can confirm that the test suite passes on both commits that landed, so no bisect has been harmed :) The guidelines are vague on what constitutes an atomic commit, so it’s a judgement call to make and both decisions would have been correct: it could have landed as one commit, it could have landed as two commits.
FYI the CQ handles fixup commits fine (i.e. it squashes the fixup commit into the one it targets before pushing to main).

PR-URL: nodejs#50074 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: #50074 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

UlisesGascon · 2023-12-10T16:15:56Z

@H4ad this commit didn’t land cleanly on v20.x-staging. Could you please open a manual backport?

PR-URL: nodejs#50074 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Backport-PR-URL: nodejs#50074

PR-URL: #50074 Backport-PR-URL: #51306 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 7, 2023

anonrig reviewed Oct 7, 2023

View reviewed changes

H4ad force-pushed the perf/perf_hooks_histogram branch 2 times, most recently from 76fb187 to d58450a Compare October 9, 2023 23:41

perf_hooks: reduce overhead of createHistogram

84d042c

H4ad marked this pull request as ready for review October 10, 2023 22:01

H4ad force-pushed the perf/perf_hooks_histogram branch from d58450a to 84d042c Compare October 10, 2023 22:01

H4ad changed the title ~~perf: reduce overhead of createHistogram~~ perf_hooks: reduce overhead of createHistogram Oct 10, 2023

Qard approved these changes Oct 10, 2023

View reviewed changes

lib/internal/histogram.js Show resolved Hide resolved

mcollina approved these changes Oct 11, 2023

View reviewed changes

Qard added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2023

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023

RafaelGSS approved these changes Oct 15, 2023

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023

test: avoid v8 deadcode on performance function

f0e81e0

fixup! test: avoid v8 deadcode on performance function

8c2169f

RafaelGSS reviewed Oct 18, 2023

View reviewed changes

benchmark/perf_hooks/histogram.js Outdated Show resolved Hide resolved

H4ad added 2 commits October 18, 2023 18:03

fixup! test: avoid v8 deadcode on performance function

bab454c

fixup! perf_hooks: reduce overhead of createHistogram

34c403e

H4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023

github-actions bot mentioned this pull request Oct 20, 2023

CI Reliability 2023-10-20 nodejs/reliability#692

Open

20 tasks

github-actions bot mentioned this pull request Oct 21, 2023

CI Reliability 2023-10-21 nodejs/reliability#693

Open

24 tasks

H4ad deleted the perf/perf_hooks_histogram branch October 23, 2023 12:41

github-actions bot mentioned this pull request Oct 24, 2023

CI Reliability 2023-10-24 nodejs/reliability#696

Open

27 tasks

targos pushed a commit that referenced this pull request Nov 11, 2023

perf_hooks: reduce overhead of createHistogram

905ca00

PR-URL: #50074 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

targos pushed a commit that referenced this pull request Nov 11, 2023

test: avoid v8 deadcode on performance function

ad31641

PR-URL: #50074 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

targos mentioned this pull request Nov 12, 2023

v21.2.0 release proposal #50681

Merged

UlisesGascon added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Dec 10, 2023

H4ad mentioned this pull request Dec 28, 2023

[v20.x backport] perf_hooks: reduce overhead of createHistogram #51306

Closed

H4ad added backport-open-v20.x Indicate that the PR has an open backport and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels Dec 28, 2023

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed backport-open-v20.x Indicate that the PR has an open backport labels Sep 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf_hooks: reduce overhead of createHistogram #50074

perf_hooks: reduce overhead of createHistogram #50074

H4ad commented Oct 7, 2023 •

edited

Loading

anonrig Oct 7, 2023

H4ad Oct 7, 2023 •

edited

Loading

Qard left a comment

mcollina left a comment

H4ad commented Oct 12, 2023

nodejs-github-bot commented Oct 15, 2023

H4ad commented Oct 18, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 20, 2023

nodejs-github-bot commented Oct 21, 2023

RafaelGSS commented Oct 25, 2023

H4ad commented Oct 25, 2023

RafaelGSS commented Oct 25, 2023 •

edited

Loading

aduh95 commented Oct 25, 2023 •

edited

Loading

UlisesGascon commented Dec 10, 2023

perf_hooks: reduce overhead of createHistogram #50074

perf_hooks: reduce overhead of createHistogram #50074

Conversation

H4ad commented Oct 7, 2023 • edited Loading

anonrig Oct 7, 2023

Choose a reason for hiding this comment

H4ad Oct 7, 2023 • edited Loading

Choose a reason for hiding this comment

Qard left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

H4ad commented Oct 12, 2023

nodejs-github-bot commented Oct 15, 2023

H4ad commented Oct 18, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 20, 2023

nodejs-github-bot commented Oct 21, 2023

RafaelGSS commented Oct 25, 2023

H4ad commented Oct 25, 2023

RafaelGSS commented Oct 25, 2023 • edited Loading

aduh95 commented Oct 25, 2023 • edited Loading

UlisesGascon commented Dec 10, 2023

H4ad commented Oct 7, 2023 •

edited

Loading

H4ad Oct 7, 2023 •

edited

Loading

RafaelGSS commented Oct 25, 2023 •

edited

Loading

aduh95 commented Oct 25, 2023 •

edited

Loading