Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add stacktrace to fs/promises #49849

Merged
merged 5 commits into from
Oct 26, 2023
Merged

fs: add stacktrace to fs/promises #49849

merged 5 commits into from
Oct 26, 2023

Commits on Oct 12, 2023

  1. fs: add stacktrace to fs/promises 

    Sync functions in fs throwed an error with a stacktrace which is helpful
for debugging. But functions in fs/promises throwed an error without
a stacktrace. This commit adds stacktraces by calling
Error.captureStacktrace and re-throwing the error.

Refs: nodejs#34817
    @sapphi-red
    sapphi-red committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b303274 View commit details
    Browse the repository at this point in the history

  2. fixup! make it work with closures as well

    @sapphi-red
    sapphi-red committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    017ac3c View commit details
    Browse the repository at this point in the history

  3. fixup! use PromisePrototypeThen instead of .catch

    @sapphi-red
    sapphi-red committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    92016f0 View commit details
    Browse the repository at this point in the history

  4. fixup! add comment to handleErrorFromBinding 

    Co-authored-by: Joyee Cheung <[email protected]>
    @sapphi-red @joyeecheung
    sapphi-red and joyeecheung committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    984d81c View commit details
    Browse the repository at this point in the history

  5. fixup! fix lint issues

    @sapphi-red
    sapphi-red committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b7d6550 View commit details
    Browse the repository at this point in the history