Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: modify int to uint16_t for HostPort #49845

Closed
wants to merge 1 commit into from
Closed

src: modify int to uint16_t for HostPort #49845

wants to merge 1 commit into from

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Sep 25, 2023

I modified Todo of HostPort.
For HostPort, int was modified to uint16_t.

Refs: #24772

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 25, 2023
@pluris pluris changed the title src: modify int to uint16_t for src: modify int to uint16_t for HostPort Sep 25, 2023
@anonrig
Copy link
Member

anonrig commented Sep 25, 2023

Duplicate of #49151

@anonrig anonrig marked this as a duplicate of #49151 Sep 25, 2023
@pluris pluris closed this Sep 25, 2023
@pluris
Copy link
Contributor Author

pluris commented Sep 25, 2023 •
edited
Loading

@anonrig Thank you your comment. I missed opened PR. 😭

@pluris pluris deleted the feat/fix_todo_port branch November 8, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pluris @anonrig @nodejs-github-bot