-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace forEach() with for ... of in test-accessor-properties.js #49773
test: replace forEach() with for ... of in test-accessor-properties.js #49773
Conversation
@dingbx This is ready to land, however, the email address that you used for the commit is not associated with your GitHub account. We strongly recommend to either add your committer email address to your GitHub account, or to change your local committer email address to one that is already associated with your GitHub account. |
Hi @tniessen , thanks for your reminder, I've added my commit email to my github account. The PR seems to be only mergable with authorized users. Does it mean I don't need to do anything to get it in? |
@dingbx Thank you! Unfortunately, we cannot merge PR branches that contain merge commits since those potentially introduce non-linear commit histories. Please either remove the unnecessary merge commit from your branch or let me know if you'd like me to do so. |
We are closing it because we have not received any updates after requesting the change. |
Replace forEach() with for ... of in test-accessor-properties.js
Grace Hopper Day - pull request to replace forEach.