Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Migrate message error tests from Python to JS #49738

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: Migrate message error tests from Python to JS #49738

wants to merge 3 commits into from
+53 −20

Conversation

akhateeb22
Copy link

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 20, 2023
@akhateeb22 akhateeb22 mentioned this pull request Sep 20, 2023
Open
MoLow
MoLow reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor fix needed

@akhateeb22
Copy link
Author

@MoLow, Committed, Thank you

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 20, 2023
@akhateeb22
Copy link
Author

@MoLow Hello, Thanks for reviewing, I committed some changes

atlowChemi
atlowChemi reviewed Sep 20, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
atlowChemi
atlowChemi reviewed Sep 20, 2023
View reviewed changes
test/fixtures/assert/assert_throws_stack.snapshot
Comment on lines -22 to -25
at assert.throws.bar (*assert_throws_stack.js:*)
at getActual (node:assert:*)
at Function.throws (node:assert:*)
at Object.<anonymous> (*assert_throws_stack.js:*:*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the test checking exactly for this stack?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test should check for it exactly ?, current test generates:

  at * {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: Error: foo
      at *
      at *
      at *
      at *
      at *
      at *
      at *
      at *
      at *
      at node:internal*main*run_main_module**,
  expected: { bar: true },
  operator: 'throws'
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the original PR adding this test: #27243
@BridgeAR is this test intended to snapshot the entire stack trace? is this change ok?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea or suggestions to close this PR ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add another trasnform function to make this snapshot similar to the original one?

@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

This needs a rebase to solve the git conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi left review comments

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akhateeb22 @aduh95 @MoLow @atlowChemi @nodejs-github-bot