crypto: simplify assertions in Safe*Print #49709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
tniessen
approved these changes
Sep 18, 2023
Done |
tniessen
approved these changes
Sep 20, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Sep 21, 2023
tniessen
added
request-ci
github-actions
bot
added
request-ci-failed
This comment was marked as off-topic.
This comment was marked as off-topic.
panva
added
request-ci
github-actions
bot
removed
the
request-ci
|
What's the status of this? Anything else needed before it can be merged? |
github-actions
bot
removed
the
request-ci
|
The https://ci.nodejs.org/job/node-test-commit-freebsd/54284/ failure is because this PR is old enough that the branch gets detected as being for Node.js 21 instead of 22 (we stopped running the freebsd CI for Node.js 22). A rebase would fix that. |
Checking the X509V3_EXT_METHOD doesn't do anything. X509V3_EXT_get is already implemented by calling X509V3_EXT_get_nid on the extension's NID. We may as well just check the NID directly.
|
Rebased. |
richardlau
approved these changes
Apr 19, 2024
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9790ddf |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
Checking the X509V3_EXT_METHOD doesn't do anything. X509V3_EXT_get is already implemented by calling X509V3_EXT_get_nid on the extension's NID. We may as well just check the NID directly. PR-URL: #49709 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Checking the X509V3_EXT_METHOD doesn't do anything. X509V3_EXT_get is already implemented by calling X509V3_EXT_get_nid on the extension's NID. We may as well just check the NID directly. PR-URL: #49709 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Checking the X509V3_EXT_METHOD doesn't do anything. X509V3_EXT_get is already implemented by calling X509V3_EXT_get_nid on the extension's NID. We may as well just check the NID directly. PR-URL: #49709 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the X509V3_EXT_METHOD doesn't do anything. X509V3_EXT_get is already implemented by calling X509V3_EXT_get_nid on the extension's NID. We may as well just check the NID directly.