contextify: use offset/length from Uint8Array #4947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not blindly take data from underlying `ArrayBuffer`, use `ByteOffset`/`ByteLength` of `Uint8Array` itself. Additionally, fix tests that weren't actually properly running because of V8's internal code cache. The code should be different, otherwise the cached data won't be used at all. Fix: nodejs#4939
mscdex
added
vm
| @@ -4,30 +4,58 @@ const assert = require('assert'); | |||
| const vm = require('vm'); | |||
| const Buffer = require('buffer').Buffer; | |||
|
|
|||
| const originalSource = '(function bcd() { return \'original\'; })'; | |||
| function getSource(tag) { | |||
| return '(function ' + tag + '() { return \'' + tag + '\'; })'; | |||
|
LGTM with a suggestion. |
|
Landed in b4ece1b, thank you! |
indutny
added a commit
that referenced
this pull request
Jan 29, 2016
Do not blindly take data from underlying `ArrayBuffer`, use `ByteOffset`/`ByteLength` of `Uint8Array` itself. Additionally, fix tests that weren't actually properly running because of V8's internal code cache. The code should be different, otherwise the cached data won't be used at all. Fix: #4939 PR-URL: #4947 Reviewed-By: Ben Noordhuis <[email protected]>
|
lts-watch label applied |
rvagg
pushed a commit
that referenced
this pull request
Feb 10, 2016
Do not blindly take data from underlying `ArrayBuffer`, use `ByteOffset`/`ByteLength` of `Uint8Array` itself. Additionally, fix tests that weren't actually properly running because of V8's internal code cache. The code should be different, otherwise the cached data won't be used at all. Fix: #4939 PR-URL: #4947 Reviewed-By: Ben Noordhuis <[email protected]>
|
dropping LTS label based on what @indutny said. Feel free to update |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Do not blindly take data from underlying `ArrayBuffer`, use `ByteOffset`/`ByteLength` of `Uint8Array` itself. Additionally, fix tests that weren't actually properly running because of V8's internal code cache. The code should be different, otherwise the cached data won't be used at all. Fix: nodejs#4939 PR-URL: nodejs#4947 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not blindly take data from underlying
ArrayBuffer, useByteOffset/ByteLengthofUint8Arrayitself.Additionally, fix tests that weren't actually properly running because
of V8's internal code cache. The code should be different, otherwise the
cached data won't be used at all.
Fix: #4939
R = @nodejs/v8 or @trevnorris