test: add and use spawnSyncAndExit() and spawnSyncAndExitWithoutError() #49200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces expectSyncExit() and expectSyncExitWithoutError(). Since we usually just check the child process right after its spawned, these shorthands also takes care of the spawning. This makes the tests more concise.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
LiviaMedeiros
approved these changes
Aug 17, 2023
32 tasks
|
Note to self: switch to this in the SEA test utils, SEA tests have been flaky without useful information in the CI error logs because the sea test utils uses |
aduh95
approved these changes
Aug 18, 2023
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 64a5c01 |
This was referenced Aug 21, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
Replaces expectSyncExit() and expectSyncExitWithoutError(). Since we usually just check the child process right after its spawned, these shorthands also takes care of the spawning. This makes the tests more concise. PR-URL: #49200 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces expectSyncExit() and expectSyncExitWithoutError(). Since
we usually just check the child process right after its spawned,
these shorthands also takes care of the spawning. This makes the
tests more concise.
I just realized that these shorthands may be more handy in some cases, so added them and switched to these instead (before we start to use them everywhere)