Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix comment on StreamResource #49193

Closed
wants to merge 1 commit into from
Closed

Conversation

ywave620
Copy link
Contributor

@ywave620 ywave620 commented Aug 16, 2023

There is no function call EmitData in src directory. I deduce that the original author was talking StreamResource::EmitRead()

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 16, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2023
@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Sep 7, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49193
✔  Done loading data for nodejs/node/pull/49193
----------------------------------- PR info ------------------------------------
Title      src: fix comment on StreamResource (#49193)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ywave620:fix-comment -> nodejs:main
Labels     c++
Commits    1
 - src: fix comment on StreamResource
Committers 1
 - rogertyang 
PR-URL: https://github.com/nodejs/node/pull/49193
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49193
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 16 Aug 2023 08:22:57 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49193#pullrequestreview-1585062540
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-08-26T11:02:31Z: https://ci.nodejs.org/job/node-test-pull-request/53564/
- Querying data for job/node-test-pull-request/53564/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6107731457

lpinca pushed a commit that referenced this pull request Sep 7, 2023
@lpinca
Copy link
Member

lpinca commented Sep 7, 2023

Landed in c86e700.

@lpinca lpinca closed this Sep 7, 2023
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
This was referenced Sep 28, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants