doc,test: add known path resolution issue in permission model #49155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
force-pushed
the
doc_test-pm-path-resolution
branch
from
517748a
to
946da0a
Compare
tniessen
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Aug 22, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Aug 24, 2023
RafaelGSS
reviewed
Aug 27, 2023
tniessen
force-pushed
the
doc_test-pm-path-resolution
branch
from
946da0a
to
e71525d
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
The |
Unfortunately node-test-commit-arm-fanned and node-test-commit-windows-fanned are going to be broken until this is resolved. I've opened nodejs/build#3475 -- I won't be able to log onto the machine until Tuesday but maybe someone else with access will be able to take a look before then. |
This was referenced Aug 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference.
tniessen
force-pushed
the
doc_test-pm-path-resolution
branch
from
e71525d
to
5f4527e
Compare
|
Should work now, hopefully. The problem on Windows appears to be that, while most modern operating systems resolve symlinks while parsing a path, Windows doesn't. Literal UNC paths seem to bypass normalization on Windows, but they are subject to other restrictions that are incompatible with the test. |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
This comment was marked as outdated.
This comment was marked as outdated.
|
@nodejs/security-wg This needs to be re-approved. |
18 tasks
RafaelGSS
approved these changes
Aug 31, 2023
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a81d5e1 |
This was referenced Sep 1, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference. PR-URL: #49155 Reviewed-By: Rafael Gonzaga <[email protected]>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference. PR-URL: nodejs#49155 Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect of 205f1e6, Node.js now resolves some paths differently when the permission model is enabled. While these are mostly edge cases, they are worth mentioning in the documentation. This commit also adds a known_issues test that demonstrates one such difference.