build: drop support for Visual Studio 2019 #49051

targos · 2023-08-07T14:09:34Z

V8 and Chromium are starting to use C++20 features. Only Visual Studio 2022 17.6 includes a version of MSVC with sufficient C++20 support to compile V8.

Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275
Refs: #45427

/cc @nodejs/build @nodejs/platform-windows

nodejs-github-bot · 2023-08-07T14:09:42Z

Review requested:

@nodejs/actions

BUILDING.md

targos · 2023-08-08T06:33:29Z

@nodejs/tsc

mcollina

lgtm

nodejs-github-bot · 2023-08-10T07:22:57Z

Commit Queue failed

- Loading data for nodejs/node/pull/49051
✔  Done loading data for nodejs/node/pull/49051
----------------------------------- PR info ------------------------------------
Title      build: drop support for Visual Studio 2019 (#49051)
Author     Michaël Zasso  (@targos)
Branch     targos:rm-vs2019 -> nodejs:main
Labels     doc, windows, semver-major, build, meta, tools, needs-ci
Commits    2
 - build: drop support for Visual Studio 2019
 - fixup! build: drop support for Visual Studio 2019
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/49051
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275
Refs: https://github.com/nodejs/node/pull/45427
Reviewed-By: Luigi Pinca 
Reviewed-By: Jiawen Geng 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49051
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275
Refs: https://github.com/nodejs/node/pull/45427
Reviewed-By: Luigi Pinca 
Reviewed-By: Jiawen Geng 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 07 Aug 2023 14:09:34 GMT
   ✔  Approvals: 7
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49051#pullrequestreview-1566036308
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/49051#pullrequestreview-1566404630
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49051#pullrequestreview-1566650747
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49051#pullrequestreview-1566864077
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49051#pullrequestreview-1566889975
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49051#pullrequestreview-1566952008
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/49051#pullrequestreview-1566990067
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/5818132910

targos · 2023-08-10T08:02:31Z

@gengjiawen this needs CI changes before we can land it.

lpinca · 2023-08-10T13:16:22Z

I think we should also update BUILDING.md and tools/bootstrap/windows_boxstarter here or after this lands.

targos · 2023-08-10T13:38:41Z

@lpinca Both files are updated in this PR

aduh95 · 2023-09-29T10:38:17Z

This needs a rebase.

Refs: nodejs/node#49051

V8 and Chromium are starting to use C++20 features. Only Visual Studio 2022 17.6 includes a version of MSVC with sufficient C++20 support to compile V8. Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275 Refs: nodejs#45427

targos · 2023-10-07T07:02:53Z

Rebased. Please someone review again.

nodejs-github-bot · 2023-10-07T07:03:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54594/

nodejs-github-bot · 2023-10-07T09:30:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54596/

nodejs-github-bot · 2023-10-09T16:25:34Z

Landed in ac2a68c

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) #45684 esm: * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) #49144 fs: * add flush option to writeFile() functions (Colin Ihrig) #50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * optimize Writable (Robert Nagy) #50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 Semver-Major Commits: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #49639 * (SEMVER-MAJOR) drop support for Visual Studio 2019 (Michaël Zasso) #49051 * (SEMVER-MAJOR) bump supported macOS and Xcode versions (Michaël Zasso) #49164 * (SEMVER-MAJOR) do not overwrite _writableState.defaultEncoding (Tobias Nießen) #49140 * (SEMVER-MAJOR) bump minimum ICU version to 73 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 8ec2651fbdd8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 89b3702c92b0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick de9a5de2274f (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick b5b5d6c31bb0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 93b1a74cbc9b (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 1a3ecc2483b2 (Michaël Zasso) #49639 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #49639 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #49639 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #49639 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #49639 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 to 11.8.172.13 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update llhttp to 9.1.2 (Paolo Insogna) #48981 * (SEMVER-MAJOR) validate options of `on` and `once` (Deokjin Kim) #46018 * (SEMVER-MAJOR) adjust `position` validation in reading methods (Livia Medeiros) #42835 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 * (SEMVER-MAJOR) update usage of always on Atomics API (Michaël Zasso) #49639 * (SEMVER-MAJOR) mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) #47497 * (SEMVER-MAJOR) remove aix directory case for package reader (Yagiz Nizipli) #48605 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 * (SEMVER-MAJOR) runtime deprecate punycode (Yagiz Nizipli) #47202 * (SEMVER-MAJOR) harmonize error code between ESM and CJS (Antoine du Hamel) #48606 * (SEMVER-MAJOR) do not treat `server.maxConnections=0` as `Infinity` (ignoramous) #48276 * (SEMVER-MAJOR) only defer _final call when connecting (Jason Zhang) #47385 * (SEMVER-MAJOR) rename internal NAPI_VERSION definition (Chengzhong Wu) #48501 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 120 (Michaël Zasso) #49639 * (SEMVER-MAJOR) throw DOMException on cloning non-serializable objects (Chengzhong Wu) #47839 * (SEMVER-MAJOR) throw DataCloneError on transfering untransferable objects (Chengzhong Wu) #47604 * (SEMVER-MAJOR) use private properties for strategies (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for encoding (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for compression (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) skip v8-updates/test-linux-perf (Michaël Zasso) #49639 * (SEMVER-MAJOR) skip test-tick-processor-arguments on SmartOS (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt REPL test to V8 changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt test-fs-write to V8 internal changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) update flag to disable SharedArrayBuffer (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt debugger tests to V8 11.4 (Philip Pfaffe) #49639 * (SEMVER-MAJOR) disallow array in `run` options (Raz Luvaton) #49935 * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 * (SEMVER-MAJOR) use `validateNumber` for `options.minDHSize` (Deokjin Kim) #49973 * (SEMVER-MAJOR) use validateFunction for `options.checkServerIdentity` (Deokjin Kim) #49896 * (SEMVER-MAJOR) add new V8 headers to distribution (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.7 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.6 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.5 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.4 (Michaël Zasso) #49639 * (SEMVER-MAJOR) runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) #49609 * (SEMVER-MAJOR) freeze `dependencySpecifiers` array (Antoine du Hamel) #49720 PR-URL: #49870 Co-authored-by: Michaël Zasso <[email protected]>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) #45684 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) #49144 fs: * add flush option to writeFile() functions (Colin Ihrig) #50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 http: * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) #50167 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 stream: * optimize Writable (Robert Nagy) #50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 Semver-Major Commits: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #49639 * (SEMVER-MAJOR) drop support for Visual Studio 2019 (Michaël Zasso) #49051 * (SEMVER-MAJOR) bump supported macOS and Xcode versions (Michaël Zasso) #49164 * (SEMVER-MAJOR) do not overwrite _writableState.defaultEncoding (Tobias Nießen) #49140 * (SEMVER-MAJOR) bump minimum ICU version to 73 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 8ec2651fbdd8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 89b3702c92b0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick de9a5de2274f (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick b5b5d6c31bb0 (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 93b1a74cbc9b (Michaël Zasso) #49639 * (SEMVER-MAJOR) V8: cherry-pick 1a3ecc2483b2 (Michaël Zasso) #49639 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #49639 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #49639 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #49639 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #49639 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 to 11.8.172.13 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update llhttp to 9.1.2 (Paolo Insogna) #48981 * (SEMVER-MAJOR) validate options of `on` and `once` (Deokjin Kim) #46018 * (SEMVER-MAJOR) adjust `position` validation in reading methods (Livia Medeiros) #42835 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) #50167 * (SEMVER-MAJOR) update usage of always on Atomics API (Michaël Zasso) #49639 * (SEMVER-MAJOR) mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) #47497 * (SEMVER-MAJOR) remove aix directory case for package reader (Yagiz Nizipli) #48605 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 * (SEMVER-MAJOR) runtime deprecate punycode (Yagiz Nizipli) #47202 * (SEMVER-MAJOR) harmonize error code between ESM and CJS (Antoine du Hamel) #48606 * (SEMVER-MAJOR) do not treat `server.maxConnections=0` as `Infinity` (ignoramous) #48276 * (SEMVER-MAJOR) only defer _final call when connecting (Jason Zhang) #47385 * (SEMVER-MAJOR) rename internal NAPI_VERSION definition (Chengzhong Wu) #48501 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 120 (Michaël Zasso) #49639 * (SEMVER-MAJOR) throw DOMException on cloning non-serializable objects (Chengzhong Wu) #47839 * (SEMVER-MAJOR) throw DataCloneError on transfering untransferable objects (Chengzhong Wu) #47604 * (SEMVER-MAJOR) use private properties for strategies (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for encoding (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) use private properties for compression (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) skip v8-updates/test-linux-perf (Michaël Zasso) #49639 * (SEMVER-MAJOR) skip test-tick-processor-arguments on SmartOS (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt REPL test to V8 changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt test-fs-write to V8 internal changes (Michaël Zasso) #49639 * (SEMVER-MAJOR) update flag to disable SharedArrayBuffer (Michaël Zasso) #49639 * (SEMVER-MAJOR) adapt debugger tests to V8 11.4 (Philip Pfaffe) #49639 * (SEMVER-MAJOR) disallow array in `run` options (Raz Luvaton) #49935 * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 * (SEMVER-MAJOR) use `validateNumber` for `options.minDHSize` (Deokjin Kim) #49973 * (SEMVER-MAJOR) use validateFunction for `options.checkServerIdentity` (Deokjin Kim) #49896 * (SEMVER-MAJOR) add new V8 headers to distribution (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.8 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.7 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.6 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.5 (Michaël Zasso) #49639 * (SEMVER-MAJOR) update V8 gypfiles for 11.4 (Michaël Zasso) #49639 * (SEMVER-MAJOR) runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) #49609 * (SEMVER-MAJOR) freeze `dependencySpecifiers` array (Antoine du Hamel) #49720 PR-URL: #49870 Co-authored-by: Michaël Zasso <[email protected]>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) #45684 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) #49144 fs: * add flush option to writeFile() functions (Colin Ihrig) #50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) #47653 http: * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) #50167 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 stream: * optimize Writable (Robert Nagy) #50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) #47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950 Semver-Major Commits: * (SEMVER-MAJOR) build: drop support for Visual Studio 2019 (Michaël Zasso) #49051 * (SEMVER-MAJOR) build: bump supported macOS and Xcode versions (Michaël Zasso) #49164 * (SEMVER-MAJOR) crypto: do not overwrite \_writableState.defaultEncoding (Tobias Nießen) #49140 * (SEMVER-MAJOR) deps: bump minimum ICU version to 73 (Michaël Zasso) #49639 * (SEMVER-MAJOR) deps: update V8 to 11.8.172.13 (Michaël Zasso) #49639 * (SEMVER-MAJOR) deps: update llhttp to 9.1.2 (Paolo Insogna) #48981 * (SEMVER-MAJOR) events: validate options of `on` and `once` (Deokjin Kim) #46018 * (SEMVER-MAJOR) fs: adjust `position` validation in reading methods (Livia Medeiros) #42835 * (SEMVER-MAJOR) fs: add globSync implementation (Moshe Atlow) #47653 * (SEMVER-MAJOR) http: reduce parts in chunked response when corking (Robert Nagy) #50167 * (SEMVER-MAJOR) lib: mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) #47497 * (SEMVER-MAJOR) lib: remove aix directory case for package reader (Yagiz Nizipli) #48605 * (SEMVER-MAJOR) lib: add `navigator.hardwareConcurrency` (Yagiz Nizipli) #47769 * (SEMVER-MAJOR) lib: runtime deprecate punycode (Yagiz Nizipli) #47202 * (SEMVER-MAJOR) module: harmonize error code between ESM and CJS (Antoine du Hamel) #48606 * (SEMVER-MAJOR) net: do not treat `server.maxConnections=0` as `Infinity` (ignoramous) #48276 * (SEMVER-MAJOR) net: only defer \_final call when connecting (Jason Zhang) #47385 * (SEMVER-MAJOR) node-api: rename internal NAPI\_VERSION definition (Chengzhong Wu) #48501 * (SEMVER-MAJOR) src: update NODE\_MODULE\_VERSION to 120 (Michaël Zasso) #49639 * (SEMVER-MAJOR) src: throw DOMException on cloning non-serializable objects (Chengzhong Wu) #47839 * (SEMVER-MAJOR) src: throw DataCloneError on transfering untransferable objects (Chengzhong Wu) #47604 * (SEMVER-MAJOR) stream: use private properties for strategies (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) stream: use private properties for encoding (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) stream: use private properties for compression (Yagiz Nizipli) #47218 * (SEMVER-MAJOR) test\_runner: disallow array in `run` options (Raz Luvaton) #49935 * (SEMVER-MAJOR) test\_runner: support passing globs (Moshe Atlow) #47653 * (SEMVER-MAJOR) tls: use `validateNumber` for `options.minDHSize` (Deokjin Kim) #49973 * (SEMVER-MAJOR) tls: use validateFunction for `options.checkServerIdentity` (Deokjin Kim) #49896 * (SEMVER-MAJOR) util: runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) #49609 * (SEMVER-MAJOR) vm: freeze `dependencySpecifiers` array (Antoine du Hamel) #49720 PR-URL: #49870 Co-authored-by: Michaël Zasso <[email protected]>

V8 and Chromium are starting to use C++20 features. Only Visual Studio 2022 17.6 includes a version of MSVC with sufficient C++20 support to compile V8. Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275 Refs: nodejs#45427 PR-URL: nodejs#49051 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Notable Changes: doc: * promote fetch/webstreams from experimental to stable (Steven) nodejs#45684 esm: * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869 * remove `globalPreload` hook (superseded by `initialize`) (Jacob Smith) nodejs#49144 fs: * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009 * (SEMVER-MAJOR) add globSync implementation (Moshe Atlow) nodejs#47653 http: * (SEMVER-MAJOR) reduce parts in chunked response when corking (Robert Nagy) nodejs#50167 lib: * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830 * (SEMVER-MAJOR) add `navigator.hardwareConcurrency` (Yagiz Nizipli) nodejs#47769 stream: * optimize Writable (Robert Nagy) nodejs#50012 test_runner: * (SEMVER-MAJOR) support passing globs (Moshe Atlow) nodejs#47653 vm: * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950 Semver-Major Commits: * (SEMVER-MAJOR) build: drop support for Visual Studio 2019 (Michaël Zasso) nodejs#49051 * (SEMVER-MAJOR) build: bump supported macOS and Xcode versions (Michaël Zasso) nodejs#49164 * (SEMVER-MAJOR) crypto: do not overwrite \_writableState.defaultEncoding (Tobias Nießen) nodejs#49140 * (SEMVER-MAJOR) deps: bump minimum ICU version to 73 (Michaël Zasso) nodejs#49639 * (SEMVER-MAJOR) deps: update V8 to 11.8.172.13 (Michaël Zasso) nodejs#49639 * (SEMVER-MAJOR) deps: update llhttp to 9.1.2 (Paolo Insogna) nodejs#48981 * (SEMVER-MAJOR) events: validate options of `on` and `once` (Deokjin Kim) nodejs#46018 * (SEMVER-MAJOR) fs: adjust `position` validation in reading methods (Livia Medeiros) nodejs#42835 * (SEMVER-MAJOR) fs: add globSync implementation (Moshe Atlow) nodejs#47653 * (SEMVER-MAJOR) http: reduce parts in chunked response when corking (Robert Nagy) nodejs#50167 * (SEMVER-MAJOR) lib: mark URL/URLSearchParams as uncloneable and untransferable (Chengzhong Wu) nodejs#47497 * (SEMVER-MAJOR) lib: remove aix directory case for package reader (Yagiz Nizipli) nodejs#48605 * (SEMVER-MAJOR) lib: add `navigator.hardwareConcurrency` (Yagiz Nizipli) nodejs#47769 * (SEMVER-MAJOR) lib: runtime deprecate punycode (Yagiz Nizipli) nodejs#47202 * (SEMVER-MAJOR) module: harmonize error code between ESM and CJS (Antoine du Hamel) nodejs#48606 * (SEMVER-MAJOR) net: do not treat `server.maxConnections=0` as `Infinity` (ignoramous) nodejs#48276 * (SEMVER-MAJOR) net: only defer \_final call when connecting (Jason Zhang) nodejs#47385 * (SEMVER-MAJOR) node-api: rename internal NAPI\_VERSION definition (Chengzhong Wu) nodejs#48501 * (SEMVER-MAJOR) src: update NODE\_MODULE\_VERSION to 120 (Michaël Zasso) nodejs#49639 * (SEMVER-MAJOR) src: throw DOMException on cloning non-serializable objects (Chengzhong Wu) nodejs#47839 * (SEMVER-MAJOR) src: throw DataCloneError on transfering untransferable objects (Chengzhong Wu) nodejs#47604 * (SEMVER-MAJOR) stream: use private properties for strategies (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) stream: use private properties for encoding (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) stream: use private properties for compression (Yagiz Nizipli) nodejs#47218 * (SEMVER-MAJOR) test\_runner: disallow array in `run` options (Raz Luvaton) nodejs#49935 * (SEMVER-MAJOR) test\_runner: support passing globs (Moshe Atlow) nodejs#47653 * (SEMVER-MAJOR) tls: use `validateNumber` for `options.minDHSize` (Deokjin Kim) nodejs#49973 * (SEMVER-MAJOR) tls: use validateFunction for `options.checkServerIdentity` (Deokjin Kim) nodejs#49896 * (SEMVER-MAJOR) util: runtime deprecate `promisify`-ing a function returning a `Promise` (Antoine du Hamel) nodejs#49609 * (SEMVER-MAJOR) vm: freeze `dependencySpecifiers` array (Antoine du Hamel) nodejs#49720 PR-URL: nodejs#49870 Co-authored-by: Michaël Zasso <[email protected]>

V8 and Chromium are starting to use C++20 features. Only Visual Studio 2022 17.6 includes a version of MSVC with sufficient C++20 support to compile V8. Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275 Refs: nodejs#45427 PR-URL: nodejs#49051 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 7, 2023

targos commented Aug 7, 2023

View reviewed changes

BUILDING.md Outdated Show resolved Hide resolved

lpinca approved these changes Aug 7, 2023

View reviewed changes

gengjiawen approved these changes Aug 8, 2023

View reviewed changes

UlisesGascon approved these changes Aug 8, 2023

View reviewed changes

aymen94 approved these changes Aug 8, 2023

View reviewed changes

mcollina approved these changes Aug 8, 2023

View reviewed changes

tniessen approved these changes Aug 8, 2023

View reviewed changes

aduh95 approved these changes Aug 8, 2023

View reviewed changes

RaisinTen approved these changes Aug 8, 2023

View reviewed changes

richardlau approved these changes Aug 8, 2023

View reviewed changes

gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 9, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 10, 2023

anonrig approved these changes Aug 10, 2023

View reviewed changes

RafaelGSS approved these changes Aug 10, 2023

View reviewed changes

targos added a commit to nodejs/build that referenced this pull request Oct 7, 2023

jenkins,doc: update supported Visual Studio for v21 (#3484)

c0a1bd0

Refs: nodejs/node#49051

build: drop support for Visual Studio 2019

8f76e1d

V8 and Chromium are starting to use C++20 features. Only Visual Studio 2022 17.6 includes a version of MSVC with sufficient C++20 support to compile V8. Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275 Refs: nodejs#45427

targos force-pushed the rm-vs2019 branch from fa9f0d9 to 8f76e1d Compare October 7, 2023 07:02

targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 7, 2023

This was referenced Oct 8, 2023

CI Reliability 2023-10-08 nodejs/reliability#687

Open

CI Reliability 2023-10-09 nodejs/reliability#688

Open

RafaelGSS approved these changes Oct 9, 2023

View reviewed changes

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2023

nodejs-github-bot merged commit ac2a68c into nodejs:main Oct 9, 2023
22 checks passed

targos deleted the rm-vs2019 branch October 9, 2023 16:28

github-actions bot mentioned this pull request Oct 10, 2023

CI Reliability 2023-10-10 nodejs/reliability#689

Open

24 tasks

RafaelGSS mentioned this pull request Oct 10, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

github-actions bot mentioned this pull request Oct 11, 2023

CI Reliability 2023-10-11 nodejs/reliability#690

Open

30 tasks

StefanStojanovic mentioned this pull request Oct 11, 2023

feat: add VCToolsVersion for msvs nodejs/gyp-next#209

Merged

kmruiz mentioned this pull request Dec 4, 2023

feat!: bump default build tools to vs2022 for Windows MONGOSH-1648 mongodb-js/boxednode#51

Open

asamuzaK mentioned this pull request Oct 30, 2024

Building binary fails on Windows with Node 22.x asamuzaK/withExEditorHost#130

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: drop support for Visual Studio 2019 #49051

build: drop support for Visual Studio 2019 #49051

targos commented Aug 7, 2023

nodejs-github-bot commented Aug 7, 2023

targos commented Aug 8, 2023

mcollina left a comment

nodejs-github-bot commented Aug 10, 2023

targos commented Aug 10, 2023

lpinca commented Aug 10, 2023

targos commented Aug 10, 2023

aduh95 commented Sep 29, 2023

targos commented Oct 7, 2023

nodejs-github-bot commented Oct 7, 2023

nodejs-github-bot commented Oct 7, 2023

nodejs-github-bot commented Oct 9, 2023

build: drop support for Visual Studio 2019 #49051

build: drop support for Visual Studio 2019 #49051

Conversation

targos commented Aug 7, 2023

nodejs-github-bot commented Aug 7, 2023

targos commented Aug 8, 2023

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 10, 2023

targos commented Aug 10, 2023

lpinca commented Aug 10, 2023

targos commented Aug 10, 2023

aduh95 commented Sep 29, 2023

targos commented Oct 7, 2023

nodejs-github-bot commented Oct 7, 2023

nodejs-github-bot commented Oct 7, 2023

nodejs-github-bot commented Oct 9, 2023