inspector: open add SymbolDispose

[atlowChemi]

No description provided.

[benjamingr]

I'm wondering if we can make the test simpler but LGTM

[atlowChemi]

I'm wondering if we can make the test simpler

I would be open to any suggestions 🙂
I based this on the existing .open() test, and did not think of anything better 😕

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52760/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52771/

[anonrig]

Since we are changing a return type of a function, should we consider this change as a semver-major?

[atlowChemi]

Since we are changing a return type of a function, should we consider this change as a semver-major?

I have thought about it, and it might be preferable. 🤔
This changes from void, so I am not sure this is actually going to cause any issues (though people might be using this very differently than I'd expect) 🤷🏽‍♂️
I do not feel strongly either way - and if you think adding it is the right thing - I am happy to do so 🙂

[MoLow]

LGTM. I would probably consider this a semver-minor. CC @nodejs/releasers

[github-actions]

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @benjamingr.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

[benjamingr]

The inspector now supports the new upcoming Symbol.dispose symbol for resource management.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/48765
✔  Done loading data for nodejs/node/pull/48765
----------------------------------- PR info ------------------------------------
Title      inspector: open add `SymbolDispose` (#48765)
Author     Chemi Atlow  (@atlowChemi)
Branch     atlowChemi:inspector-open-add-dispose -> nodejs:main
Labels     semver-minor, inspector, notable-change, author ready, needs-ci
Commits    2
 - inspector: open add `SymbolDispose`
 - fix test
Committers 1
 - atlowChemi 
PR-URL: https://github.com/nodejs/node/pull/48765
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48765
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Jul 2023 07:43:18 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48765#pullrequestreview-1529845578
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48765#pullrequestreview-1531671441
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-07-15T18:11:52Z: https://ci.nodejs.org/job/node-test-pull-request/52771/
- Querying data for job/node-test-pull-request/52771/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48765
From https://github.com/nodejs/node
 * branch                  refs/pull/48765/merge -> FETCH_HEAD
✔  Fetched commits as a4e4a86d8920..1bdf897025cb
--------------------------------------------------------------------------------
[main 254f8dd2b2] inspector: open add `SymbolDispose`
 Author: atlowChemi 
 Date: Fri Jul 14 10:28:36 2023 +0300
 3 files changed, 88 insertions(+)
 create mode 100644 test/parallel/test-inspector-open-dispose.mjs
[main f117a971e9] fix test
 Author: atlowChemi 
 Date: Sat Jul 15 21:06:22 2023 +0300
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

inspector: open add SymbolDispose
PR-URL: #48765

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Moshe Atlow [email protected]
[detached HEAD 489a9712bc] inspector: open add SymbolDispose

Author: atlowChemi [email protected]

Date: Fri Jul 14 10:28:36 2023 +0300

3 files changed, 88 insertions(+)

create mode 100644 test/parallel/test-inspector-open-dispose.mjs

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix test
PR-URL: #48765

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Moshe Atlow [email protected]
[detached HEAD 5b312876fb] fix test

Author: atlowChemi [email protected]

Date: Sat Jul 15 21:06:22 2023 +0300

1 file changed, 3 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5566971519