test: skip experimental test with pointer compression #48738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted.
|
should the test be part of |
|
I would prefer not to use |
MoLow
approved these changes
Jul 11, 2023
debadree25
added
the
author ready
debadree25
approved these changes
Jul 13, 2023
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jul 13, 2023
|
CI failures seem realted. |
richardlau
reviewed
Jul 14, 2023
Co-authored-by: Richard Lau <[email protected]>
richardlau
approved these changes
Jul 15, 2023
richardlau
added
the
commit-queue-squash
cjihrig
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48738 ✔ Done loading data for nodejs/node/pull/48738 ----------------------------------- PR info ------------------------------------ Title test: skip experimental test with pointer compression (#48738) Author Colin Ihrig (@cjihrig) Branch cjihrig:pc-test -> nodejs:main Labels test, author ready, commit-queue-squash Commits 2 - test: skip experimental test with pointer compression - Update test/parallel/test-experimental-shared-value-conveyor.js Committers 2 - cjihrig - GitHub PR-URL: https://github.com/nodejs/node/pull/48738 Reviewed-By: Moshe Atlow Reviewed-By: Michael Dawson Reviewed-By: Matteo Collina Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48738 Reviewed-By: Moshe Atlow Reviewed-By: Michael Dawson Reviewed-By: Matteo Collina Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 11 Jul 2023 16:24:54 GMT ✔ Approvals: 6 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1524698864 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1525014643 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1525697808 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48738#pullrequestreview-1529126202 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48738#pullrequestreview-1529136855 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48738#pullrequestreview-1531530821 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-07-15T16:50:49Z: https://ci.nodejs.org/job/node-test-pull-request/52768/ - Querying data for job/node-test-pull-request/52768/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5563587926 |
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a4e4a86 |
23 tasks
This was referenced Jul 17, 2023
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted. PR-URL: nodejs#48738 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted. PR-URL: nodejs#48738 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted. PR-URL: nodejs#48738 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 15, 2023
The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addresses, this commit can be reverted. PR-URL: #48738 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test test/parallel/test-experimental-shared-value-conveyor.js was added to test the --harmony-struct feature of V8. However, when used with pointer compression, the process crashes. This commit skips the test for pointer compression builds. This change uses a child process because starting a Node pointer compression build with --harmony-struct immediately crashes the process. Once this crash is addressed, this commit can be reverted.
Refs: nodejs/build#3204 (comment)