Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unneeded logic in gyp_node.py #48718

Closed
wants to merge 1 commit into from
Closed

chore: remove unneeded logic in gyp_node.py #48718

wants to merge 1 commit into from

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Jul 10, 2023 •
edited
Loading

image

I found that node_root and os.path.abspath(node_root) is basically the same

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jul 10, 2023
lpinca
lpinca previously approved these changes Jul 10, 2023
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52686/

@lpinca lpinca dismissed their stale review July 10, 2023 19:55

I guess build failures are related

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 11, 2023 •
edited
Loading

image
image

https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx11-x64/53144/console
@lpinca seems like the ssh remote machine id is changed, and we have some random test failing, I'm not sure it's related to my change

@CGQAQ CGQAQ force-pushed the remove-unneeded-logic branch from 8dedc93 to 4f7c225 Compare July 11, 2023 00:47
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52691/

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 11, 2023

really not sure what happend, close for now

@CGQAQ CGQAQ closed this Jul 11, 2023
@github-actions github-actions bot mentioned this pull request Jul 16, 2023
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca left review comments

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CGQAQ @nodejs-github-bot @lpinca