Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: todo, only, skip are expected to return a Promise #48555

Merged
merged 3 commits into from
Jul 3, 2023
Merged

test_runner: todo, only, skip are expected to return a Promise #48555

merged 3 commits into from
Jul 3, 2023

Commits on Jun 27, 2023

  1. test_runner: fixed test shorthands return type 

    `test.todo`, `test.only` and `test.skip` are expected to return the
same as `test`. This commit corrects the inconsistent behavior of
these shorthands.

Fixes: nodejs#48557
    @shockerqt
    shockerqt committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    6068403 View commit details
    Browse the repository at this point in the history

  2. test_runner: added tests for test shorthands 

    Added test to check that the return type of the `todo`, `only` and `skip` shorthands
are consistent with the return type of `test`.
    @shockerqt
    shockerqt committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    6ce6729 View commit details
    Browse the repository at this point in the history

  3. test_runner: change tests to use describe/it

    @shockerqt
    shockerqt committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    cf59fa0 View commit details
    Browse the repository at this point in the history