Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update icu to 73.2 #48502

Merged
merged 1 commit into from
Jun 23, 2023
Merged

deps: update icu to 73.2 #48502

merged 1 commit into from
Jun 23, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of icu to 73.2.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Jun 20, 2023
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2023
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau
Copy link
Member

There are a large number of whitespace only changes, I think originating from #47456 (comment). Hopefully now we have automation in place to do the updates this should be less of an issue in the future.

@richardlau richardlau removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2023
@marco-ippolito
Copy link
Member

do we still need to update thetz-version.txt manually?

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
@richardlau
Copy link
Member

do we still need to update thetz-version.txt manually?

Only if tzdata has been updated in the ICU release (which I don't think it has for this one).

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit cd28ebb into main Jun 23, 2023
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-icu branch June 23, 2023 13:50
@nodejs-github-bot
Copy link
Collaborator Author

Landed in cd28ebb

@kasicka
Copy link

kasicka commented Jul 24, 2023

Any reason why this was changed back from zip to tgz?

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48502
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48502
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #48502
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 10, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48502
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants