stream: fix premature pipeline end #48435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
marco-ippolito
approved these changes
Jun 12, 2023
debadree25
approved these changes
Jun 12, 2023
debadree25
added
author ready
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jun 12, 2023
lpinca
approved these changes
Jun 12, 2023
22 tasks
|
@nodejs/build it seems we can't build on ARM. |
|
Can you try with a full run instead of a rebuild? |
github-actions
bot
removed
the
request-ci
This was referenced Jun 14, 2023
ronag
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48435 ✔ Done loading data for nodejs/node/pull/48435 ----------------------------------- PR info ------------------------------------ Title stream: fix premature pipeline end (#48435) Author Robert Nagy (@ronag) Branch ronag:issue-48406 -> nodejs:main Labels stream, author ready, needs-ci Commits 1 - stream: fix premature pipeline end Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/48435 Fixes: https://github.com/nodejs/node/issues/48406 Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48435 Fixes: https://github.com/nodejs/node/issues/48406 Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jun 2023 13:17:11 GMT ✔ Approvals: 4 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48435#pullrequestreview-1474986414 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475174694 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475278074 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475471197 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-06-13T09:28:07Z: https://ci.nodejs.org/job/node-test-pull-request/52235/ - Querying data for job/node-test-pull-request/52235/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5277325882 |
debadree25
removed
the
commit-queue-failed
29 tasks
benjamingr
approved these changes
Jun 22, 2023
30 tasks
25 tasks
debadree25
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cebbc57 |
This was referenced Jun 25, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
Fixes: #48406 PR-URL: #48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes: nodejs#48406 PR-URL: nodejs#48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes: nodejs#48406 PR-URL: nodejs#48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 10, 2023
Fixes: #48406 PR-URL: #48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Fixes: #48406 PR-URL: #48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48406