Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Remove no longer relevant comments in debug-agent and crypto #4843

Closed
wants to merge 1 commit into from
Closed

Maintenance: Remove no longer relevant comments in debug-agent and crypto #4843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/debug-agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ void Agent::ChildSignalCb(uv_async_t* signal) {
}

// Waiting for client, do not send anything just yet
// TODO(indutny): move this to js-land
if (a->wait_) {
a->messages_.PushFront(msg); // Push message back into the ready queue.
break;
Expand Down
1 change: 0 additions & 1 deletion src/debug-agent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ class Agent {
kRunning
};

// TODO(indutny): Verify that there are no races
State state_;

int port_;
Expand Down
4 changes: 2 additions & 2 deletions src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5168,7 +5168,7 @@ void PBKDF2(const FunctionCallbackInfo<Value>& args) {

if (args[5]->IsFunction()) {
obj->Set(env->ondone_string(), args[5]);
// XXX(trevnorris): This will need to go with the rest of domains.

if (env->in_domain())
obj->Set(env->domain_string(), env->domain_array()->Get(0));
uv_queue_work(env->event_loop(),
Expand Down Expand Up @@ -5329,7 +5329,7 @@ void RandomBytes(const FunctionCallbackInfo<Value>& args) {

if (args[1]->IsFunction()) {
obj->Set(FIXED_ONE_BYTE_STRING(args.GetIsolate(), "ondone"), args[1]);
// XXX(trevnorris): This will need to go with the rest of domains.

if (env->in_domain())
obj->Set(env->domain_string(), env->domain_array()->Get(0));
uv_queue_work(env->event_loop(),
Expand Down