Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: throw a TypeError in lookupService with invalid port #4839

Merged
merged 1 commit into from
Jan 25, 2016
Merged

dns: throw a TypeError in lookupService with invalid port #4839

merged 1 commit into from
Jan 25, 2016

Commits on Jan 25, 2016

  1. dns: throw a TypeError in lookupService with invalid port 

    Previously, port was assumed to be a number and would cause an abort in
cares_wrap. This change throws a TypeError if port is not a number
before we actually hit C++.

Fixes: nodejs#4837
PR-URL: nodejs#4839
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Brian White <[email protected]>
    @evanlucas
    evanlucas committed Jan 25, 2016
    Configuration menu
    Copy the full SHA
    0f8e63c View commit details
    Browse the repository at this point in the history