-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: undo move http.IncomingMessage.statusMessage #4822
Closed
techjeffharris
wants to merge
1
commit into
nodejs:master
from
techjeffharris:doc-fix-http-incoming-status-message
Closed
doc: undo move http.IncomingMessage.statusMessage #4822
techjeffharris
wants to merge
1
commit into
nodejs:master
from
techjeffharris:doc-fix-http-incoming-status-message
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. see: nodejs#4558
LGTM |
LGTM |
Thanks! Landed in f19b9d6. |
silverwind
pushed a commit
that referenced
this pull request
Jan 24, 2016
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. PR-URL: #4822 Fixes: #4558 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jan 25, 2016
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. PR-URL: #4822 Fixes: #4558 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
LGTM! |
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. PR-URL: nodejs#4822 Fixes: nodejs#4558 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. PR-URL: #4822 Fixes: #4558 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. PR-URL: #4822 Fixes: #4558 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. PR-URL: #4822 Fixes: #4558 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The description for `statusMessage` was accidentally moved under the heading for `http.IncomingMessage.socket`. This commit puts it back in the correct place. PR-URL: nodejs#4822 Fixes: nodejs#4558 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description for
statusMessage
was accidentally moved under theheading for
http.IncomingMessage.socket
. This commit puts it backin the correct place.
/CC @nodejs/http @nodejs/documentation
Fixes: #4558