Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_contextify: do not incept debug context #4819

Merged
merged 1 commit into from
Feb 5, 2016
Merged

node_contextify: do not incept debug context #4819

merged 1 commit into from
Feb 5, 2016

Commits on Feb 5, 2016

  1. node_contextify: do not incept debug context 

    Currently a debug context is created for various calls to util.

If the node debugger is being run the main context is the debug
context. In this case node_contextify was freeing the debug context
and causing everything to explode.

This change moves around the logic and no longer frees the context.

There is a concern about the dangling pointer

The regression test was adapted from code submitted by @3y3 in nodejs#4815

Fixes: nodejs#4440
Fixes: nodejs#4815
Fixes: nodejs#4597
Fixes: nodejs#4952

PR-URL: nodejs#4815

Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
    Myles Borins committed Feb 5, 2016
    Configuration menu
    Copy the full SHA
    4897f94 View commit details
    Browse the repository at this point in the history