Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: add status napi_cannot_run_js #47986

Closed
wants to merge 9 commits into from
Closed

node-api: add status napi_cannot_run_js #47986

wants to merge 9 commits into from

Commits on May 13, 2023

  1. node-api: add status napi_cannot_run_js 

    Add the new status in order to distinguish a state wherein an exception
is pending from one wherein the engine is unable to execute JS. We take
advantage of the new runtime add-on version reporting in order to remain
forward compatible with add-ons that do not expect the new status code.
    @gabrielschulhof
    gabrielschulhof committed May 13, 2023
    Configuration menu
    Copy the full SHA
    0e89301 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. doc: update doc/api/n-api.md

    @gabrielschulhof
    gabrielschulhof committed May 16, 2023
    Configuration menu
    Copy the full SHA
    86277c9 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Update test/node-api/test_cannot_run_js/test.js 

    Co-authored-by: Chengzhong Wu <[email protected]>
    @gabrielschulhof @legendecas
    gabrielschulhof and legendecas committed May 18, 2023
    Configuration menu
    Copy the full SHA
    fa45e0a View commit details
    Browse the repository at this point in the history

  2. test: access global property to illicit error status

    @gabrielschulhof
    gabrielschulhof committed May 18, 2023
    Configuration menu
    Copy the full SHA
    95137f5 View commit details
    Browse the repository at this point in the history

  3. heed the linter

    @gabrielschulhof
    gabrielschulhof committed May 18, 2023
    Configuration menu
    Copy the full SHA
    72980e2 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. test: address nit

    @gabrielschulhof
    gabrielschulhof committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d6f3232 View commit details
    Browse the repository at this point in the history

  2. test: use variables instead of target_defaults 

    Some platforms do not seem to support target_defaults.
    @gabrielschulhof
    gabrielschulhof committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d8bee9e View commit details
    Browse the repository at this point in the history

  3. test: explicitly copy dependency

    @gabrielschulhof
    gabrielschulhof committed May 19, 2023
    Configuration menu
    Copy the full SHA
    ab54044 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. test: create job dependency to copy the common file

    @gabrielschulhof
    gabrielschulhof committed May 20, 2023
    Configuration menu
    Copy the full SHA
    128a6f8 View commit details
    Browse the repository at this point in the history