Skip to content

process: add custom dir support for heapsnapshot-signal #47854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

process: add custom dir support for heapsnapshot-signal #47854

merged 1 commit into from
Sep 5, 2023
+87 −2

Conversation

@MrJithil
Copy link
Member

@MrJithil MrJithil commented May 4, 2023

Ref: #47842

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels May 4, 2023
@MrJithil MrJithil changed the title internal: add custom dir support for heapsnapshot-signal [draft]internal: add custom dir support for heapsnapshot-signal May 4, 2023
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 18d913b to 577ffbd Compare May 4, 2023 11:10
@MrJithil MrJithil changed the title [draft]internal: add custom dir support for heapsnapshot-signal internal: add custom dir support for heapsnapshot-signal May 4, 2023
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from f6baa61 to 98cdeb0 Compare May 4, 2023 11:32
joyeecheung
joyeecheung reviewed May 4, 2023
View reviewed changes
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 98cdeb0 to 0cdc46f Compare May 5, 2023 03:52
@MrJithil MrJithil requested a review from joyeecheung May 6, 2023 02:23
@SteffenLanger SteffenLanger mentioned this pull request May 17, 2023
Closed
joyeecheung
joyeecheung reviewed May 19, 2023
View reviewed changes
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 5bbc7b0 to 1410a68 Compare May 20, 2023 06:04
@MrJithil MrJithil changed the title internal: add custom dir support for heapsnapshot-signal process: add custom dir support for heapsnapshot-signal May 20, 2023
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 1410a68 to 3ce5cac Compare May 20, 2023 06:16
@MrJithil MrJithil requested a review from joyeecheung May 20, 2023 06:17
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 10b4e01 to 5b1ce48 Compare May 21, 2023 03:48
joyeecheung
joyeecheung reviewed May 29, 2023
View reviewed changes
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 06676d9 to 3f01bc9 Compare June 9, 2023 09:09
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52197/

This was referenced Jun 11, 2023
Open
Open
Open
Open
Ceres6
Ceres6 reviewed Aug 14, 2023
View reviewed changes
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch 2 times, most recently from 067ee6e to 4e39087 Compare August 22, 2023 09:10
@MrJithil MrJithil requested a review from Ceres6 August 22, 2023 09:11
@MrJithil MrJithil force-pushed the addCwdSupportOnHeapSnapshot branch from 4e39087 to 08383f8 Compare August 22, 2023 09:12
@MrJithil
Copy link
Member Author

@benjamingr all issues resolved. Please try to land this sooner. Its opened on 4th May.

Ceres6
Ceres6 reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@Ceres6 Ceres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve, but LGTM

ErickWendel
ErickWendel approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@ErickWendel ErickWendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErickWendel ErickWendel added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53742/

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47854
✔  Done loading data for nodejs/node/pull/47854
----------------------------------- PR info ------------------------------------
Title      process: add custom dir support for heapsnapshot-signal (#47854)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MrJithil:addCwdSupportOnHeapSnapshot -> nodejs:main
Labels     process, needs-ci
Commits    1
 - process: add custom dir support for heapsnapshot-signal
Committers 1
 - Jithil P Ponnan 
PR-URL: https://github.com/nodejs/node/pull/47854
Refs: https://github.com/nodejs/node/issues/47842
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Joyee Cheung 
Reviewed-By: Erick Wendel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47854
Refs: https://github.com/nodejs/node/issues/47842
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Joyee Cheung 
Reviewed-By: Erick Wendel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 04 May 2023 09:50:48 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1419757000
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1432558181
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1473519728
   ✔  - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/47854#pullrequestreview-1611054978
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-09-05T13:31:34Z: https://ci.nodejs.org/job/node-test-pull-request/53742/
- Querying data for job/node-test-pull-request/53742/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6086313053

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53746/

@MrJithil @Trott
process: add custom dir support for heapsnapshot-signal
5402185 
PR-URL: nodejs#47854
Refs: nodejs#47842
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
@Trott Trott force-pushed the addCwdSupportOnHeapSnapshot branch from 08383f8 to 5402185 Compare September 5, 2023 22:13
@Trott Trott merged commit 5402185 into nodejs:main Sep 5, 2023
@Trott
Copy link
Member

Trott commented Sep 5, 2023

Landed in 5402185

This was referenced Sep 6, 2023
Open
Open
This was referenced Sep 16, 2023
Closed
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@MrJithil @ruyadorno
process: add custom dir support for heapsnapshot-signal
ad043ba 
PR-URL: #47854
Refs: #47842
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@MrJithil @alexfernandez
process: add custom dir support for heapsnapshot-signal
ae22ce9 
PR-URL: nodejs#47854
Refs: nodejs#47842
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@ErickWendel ErickWendel ErickWendel approved these changes

+1 more reviewer

@Ceres6 Ceres6 Ceres6 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@MrJithil @nodejs-github-bot @Ceres6 @benjamingr @Trott @jasnell @joyeecheung @ErickWendel