Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce WPT concurrency #47834

Merged
merged 1 commit into from
May 5, 2023
Merged

test: reduce WPT concurrency #47834

merged 1 commit into from
May 5, 2023

Conversation

panva
Copy link
Member

@panva panva commented May 3, 2023 •
edited
Loading

Refs: #47657 (comment)

Because of the flaky wpt/test-timers and sometimes crashing wpt/test-webcrypto this PR

  • moves the WPT test suite back to SimpleTestConfiguration
  • reduces the default WPT files concurrency by 1 to save one CPU for the WPTRunner itself
  • introduces an option to force a given concurrency for a WPT Runner so that timing sensitive suites can be ran sequentially

cc @targos @tniessen

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 3, 2023
@panva
Copy link
Member Author

panva commented May 3, 2023 •
edited
Loading

Shall we also unskip negative-settimeout.any.js? refs: #37672

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51597/

@panva panva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 3, 2023
@panva panva mentioned this pull request May 3, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51600/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51602/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2023
@github-actions github-actions bot mentioned this pull request May 4, 2023
Open
28 tasks
mhdawson
mhdawson approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request May 5, 2023
Open
22 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3d00354 into nodejs:main May 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3d00354

@panva panva deleted the lower-wpt-concurrency branch May 5, 2023 08:52
This was referenced May 6, 2023
Open
Open
Open
@panva panva mentioned this pull request May 10, 2023
Merged
targos pushed a commit that referenced this pull request May 12, 2023
@panva @targos
test: reduce WPT concurrency
54607bf 
PR-URL: #47834
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request May 15, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 4, 2023
@danielleadams danielleadams added backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Jul 4, 2023
@danielleadams
Copy link
Member

Blocked by #47635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@panva @nodejs-github-bot @danielleadams @anonrig @targos @tniessen @mhdawson