Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: introduces a new MockTimers API #47775

Merged
merged 57 commits into from
Jun 22, 2023
Merged

test_runner: introduces a new MockTimers API #47775

merged 57 commits into from
Jun 22, 2023

Commits on Apr 28, 2023

  1. test_runner: add initial draft for fakeTimers 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    568ad96 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. test_runner: move fakerTimers to mock module 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ac0fab3 View commit details
    Browse the repository at this point in the history

  2. test_runner: change fakeTimers prop name 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    e54a162 View commit details
    Browse the repository at this point in the history

  3. test_runner: implement PriorityQueue for timers 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    71ffd10 View commit details
    Browse the repository at this point in the history

  4. test_runner: add @ljharb suggestion 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    a0f8afd View commit details
    Browse the repository at this point in the history

  5. test_runner: add @benjamingr suggestion 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    0f55f65 View commit details
    Browse the repository at this point in the history

  6. test_runner: add fake setTimeout initial impl 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    e34a426 View commit details
    Browse the repository at this point in the history

  7. test_runner: add @MoLow suggestion 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    df35174 View commit details
    Browse the repository at this point in the history

  8. test_runner: fix a test 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 1, 2023
    Configuration menu
    Copy the full SHA
    e5af52f View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. test_runner: rename from fakeTimers to mockTimers 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a22321f View commit details
    Browse the repository at this point in the history

  2. test_runner: add experimental warning 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    21be0bc View commit details
    Browse the repository at this point in the history

  3. test_runner: fix tests 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    102a830 View commit details
    Browse the repository at this point in the history

  4. test_runner: add @ljharb suggestion 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1d30e47 View commit details
    Browse the repository at this point in the history

  5. test_runner: fix possible truthy evaluation on tick by @ljharb 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0cb4e7c View commit details
    Browse the repository at this point in the history

  6. test_runner: add tests for clearTimeout 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a53aedc View commit details
    Browse the repository at this point in the history

  7. test_runner: add tests for setInterval modules 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1a2cf34 View commit details
    Browse the repository at this point in the history

  8. test_runner: add tests for clearInterval modules 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 3, 2023
    Configuration menu
    Copy the full SHA
    db2a79f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. test_runner: add impl for timers.promises.setInterval function 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 4, 2023
    Configuration menu
    Copy the full SHA
    f200467 View commit details
    Browse the repository at this point in the history

  2. test_runner: fix setInterval algorithm 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 4, 2023
    Configuration menu
    Copy the full SHA
    cc652fe View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. test_runner: add abortController support for promises.setTimeout and … 

    …more tests

Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 14, 2023
    Configuration menu
    Copy the full SHA
    942f504 View commit details
    Browse the repository at this point in the history

  2. test_runner: add test cases for abortController and remove listeners … 

    …after fullfuling results

Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 14, 2023
    Configuration menu
    Copy the full SHA
    bb75287 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. test_runner: change import order 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b0baf00 View commit details
    Browse the repository at this point in the history

  2. test_runner: add ArrayPrototypeAt instead of [].at 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 15, 2023
    Configuration menu
    Copy the full SHA
    92bf115 View commit details
    Browse the repository at this point in the history

  3. test_runner: return safe asyncIterator 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1fe731e View commit details
    Browse the repository at this point in the history

  4. test_runner: make promises.setInterval update time during iterations 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 15, 2023
    Configuration menu
    Copy the full SHA
    08f27ba View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. test_runner: add __proto__ null while returning the object 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3e39782 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. test_runner: make promises.setInterval work with abortControllers 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 30, 2023
    Configuration menu
    Copy the full SHA
    a563ce9 View commit details
    Browse the repository at this point in the history

  2. test_runner: rm unsafe array iteration and comments 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 30, 2023
    Configuration menu
    Copy the full SHA
    17381f1 View commit details
    Browse the repository at this point in the history

  3. test_runner: avoid avoid code repetition 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 30, 2023
    Configuration menu
    Copy the full SHA
    3677482 View commit details
    Browse the repository at this point in the history

  4. test_runner: (rollback) avoid avoid code repetition 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 30, 2023
    Configuration menu
    Copy the full SHA
    1825426 View commit details
    Browse the repository at this point in the history

  5. test_runner: rm unecessarly PromiseRejection 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed May 30, 2023
    Configuration menu
    Copy the full SHA
    abc7c96 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. test_runner: add timers.reset on test postRun 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    87b0d36 View commit details
    Browse the repository at this point in the history

  2. test_runner: add config for choosing timers to use, error handling an… 

    …d refactoring

Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a001e65 View commit details
    Browse the repository at this point in the history

  3. test_runner: implement releaseAllTimers function 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    d168614 View commit details
    Browse the repository at this point in the history

  4. test_runner: reach 100% code coverage 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    1e09a22 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. test_runner: rename function to runAll 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    89b489b View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. fix flaky test 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    2b64a4a View commit details
    Browse the repository at this point in the history

  2. add abort once flag 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a9ed28d View commit details
    Browse the repository at this point in the history

  3. check that timeout will only be called when reaches the specified tim… 

    …eout

Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b383a1c View commit details
    Browse the repository at this point in the history

  4. fix lint problems 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ba725f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. test_runner: add initial doc 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    1bcbe65 View commit details
    Browse the repository at this point in the history

  2. test_runner: fix heading 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    7c65e64 View commit details
    Browse the repository at this point in the history

  3. test_runner: fix text 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    aaf7070 View commit details
    Browse the repository at this point in the history

  4. test_runner: fix links 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ac9f5b6 View commit details
    Browse the repository at this point in the history

  5. test_runner: add docs for timers.tick 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    13fab2b View commit details
    Browse the repository at this point in the history

  6. test_runner: add docs for timers.runAll 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    296f5b0 View commit details
    Browse the repository at this point in the history

  7. doc rm empty spaces 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a75ddb4 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Update test/parallel/test-runner-mock-timers.js 

    Co-authored-by: Moshe Atlow <[email protected]>
    @ErickWendel @MoLow
    ErickWendel and MoLow authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1bee321 View commit details
    Browse the repository at this point in the history

  2. Update lib/internal/test_runner/mock/mock_timers.js 

    Co-authored-by: Jordan Harband <[email protected]>
    @ErickWendel @ljharb
    ErickWendel and ljharb authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    bc8fea7 View commit details
    Browse the repository at this point in the history

  3. format test.md 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1bfd7b8 View commit details
    Browse the repository at this point in the history

  4. add 1ms to tick to fix flakyness

    @ErickWendel
    ErickWendel committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d2c9a1a View commit details
    Browse the repository at this point in the history

  5. test_runner: add 50ms to .tick so setInterval will not be flaky 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    93950f5 View commit details
    Browse the repository at this point in the history

  6. test_runner: revert last commit 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    49e8eba View commit details
    Browse the repository at this point in the history

  7. founde the bug 🐛

    @MoLow
    MoLow committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4d3a45c View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Tobias Nießen <[email protected]>
Co-authored-by: Colin Ihrig <[email protected]>
    @ErickWendel @tniessen @cjihrig
    3 people authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    12772d1 View commit details
    Browse the repository at this point in the history

  2. apply suggestions from review 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5c9e425 View commit details
    Browse the repository at this point in the history

  3. add info about support for destructuring from modules 

    Signed-off-by: Erick Wendel <[email protected]>
    @ErickWendel
    ErickWendel committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0424bf5 View commit details
    Browse the repository at this point in the history