v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor #47721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
approved these changes
Apr 26, 2023
github-actions
bot
removed
the
request-ci
29 tasks
legendecas
added
the
author ready
32 tasks
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47721 ✔ Done loading data for nodejs/node/pull/47721 ----------------------------------- PR info ------------------------------------ Title v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor (#47721) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:startup/err -> nodejs:main Labels author ready, needs-ci, snapshot Commits 1 - v8: fix ERR_NOT_BUILDING_SNAPSHOT is not a constructor Committers 1 - Chengzhong Wu PR-URL: https://github.com/nodejs/node/pull/47721 Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47721 Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 26 Apr 2023 07:37:04 GMT ✔ Approvals: 1 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/47721#pullrequestreview-1402519179 ✘ This PR needs to wait 87 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-27T12:15:31Z: https://ci.nodejs.org/job/node-test-pull-request/51507/ - Querying data for job/node-test-pull-request/51507/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4839548131 |
tniessen
approved these changes
Apr 29, 2023
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bddf341 |
This was referenced Apr 30, 2023
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47721 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
33 tasks
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47721 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47721 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47721 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a regression test verifying that the error is correctly constructed.