Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make realm binding data store weak #47688

Closed
wants to merge 2 commits into from
Closed

src: make realm binding data store weak #47688

wants to merge 2 commits into from

Commits on Jun 13, 2023

  1. src: remove aliased buffer weak callback 

    An AliasedBuffer can be nested in a BaseObject and their weak callbacks
invoke order are not guaranteed. Prevent aliased buffer from being
accessed in its weak callback as its validness can be checked with the
emptiness of the persistent handle.
    @legendecas
    legendecas committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    5aa1ab3 View commit details
    Browse the repository at this point in the history

  2. src: make realm binding data store weak 

    The binding data must be weak so that it won't keep the realm reachable
from strong GC roots indefinitely. The wrapper object of binding data
should be referenced from JavaScript, thus the binding data should be
reachable throughout the lifetime of the realm.
    @legendecas
    legendecas committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    952cabc View commit details
    Browse the repository at this point in the history