test_runner: avoid reporting parents of failing tests in summary #47579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
MoLow
force-pushed
the
skip-subtest-failures
branch
from
5ba622b
to
61856dc
Compare
benjamingr
approved these changes
Apr 17, 2023
MoLow
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Apr 17, 2023
|
Is this
semver-major
|
@aduh95 I think we agreed that reporters output is still experimental. #46642 (comment) |
jasnell
approved these changes
Apr 17, 2023
35 tasks
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d3b0a2a |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47579 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47579 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47579 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is a little distracting that the summary of failures includes both failing tests and their parents