Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: test passing NULL to napi_define_class #47567

Merged
merged 1 commit into from
Apr 26, 2023
Merged

node-api: test passing NULL to napi_define_class #47567

merged 1 commit into from
Apr 26, 2023

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51402/

This was referenced Apr 24, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51464/

mhdawson
mhdawson approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51466/

@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Open
36 tasks
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit 11f97d4 into nodejs:main Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 11f97d4

@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Open
35 tasks
@toyobayashi toyobayashi mentioned this pull request Apr 27, 2023
Merged
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Open
29 tasks
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@gabrielschulhof @yjl9903
node-api: test passing NULL to napi_define_class
797e7ad 
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@gabrielschulhof @yjl9903
node-api: test passing NULL to napi_define_class
251494c 
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Open
32 tasks
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@gabrielschulhof @yjl9903
node-api: test passing NULL to napi_define_class
1ad41cd 
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <[email protected]>
This was referenced Apr 30, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@gabrielschulhof @targos
node-api: test passing NULL to napi_define_class
4d02901 
PR-URL: #47567
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
@gabrielschulhof gabrielschulhof deleted the pass-null-to-napi_define_class branch May 20, 2023 01:05
@gabrielschulhof gabrielschulhof restored the pass-null-to-napi_define_class branch May 20, 2023 14:41
@gabrielschulhof gabrielschulhof deleted the pass-null-to-napi_define_class branch June 3, 2023 18:10
@gabrielschulhof gabrielschulhof restored the pass-null-to-napi_define_class branch June 5, 2023 02:21
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@gabrielschulhof @danielleadams
node-api: test passing NULL to napi_define_class
6735637 
PR-URL: #47567
Reviewed-By: Michael Dawson <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@gabrielschulhof @MoLow
node-api: test passing NULL to napi_define_class
beaad7f 
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas Awaiting requested review from legendecas

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielschulhof @nodejs-github-bot @mhdawson @lpinca