Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: test passing NULL to number APIs #47549

Merged
merged 1 commit into from
Apr 20, 2023
Merged

node-api: test passing NULL to number APIs #47549

merged 1 commit into from
Apr 20, 2023

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 13, 2023
@gabrielschulhof gabrielschulhof marked this pull request as draft April 13, 2023 18:23
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51210/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51212/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51225/

@gabrielschulhof gabrielschulhof marked this pull request as ready for review April 14, 2023 03:25
@gabrielschulhof
Copy link
Contributor Author

@nodejs/node-api please take a look!

This was referenced Apr 15, 2023
Open
Open
mhdawson
mhdawson approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51328/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51336/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2023
@nodejs-github-bot nodejs-github-bot merged commit df15a47 into nodejs:main Apr 20, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in df15a47

@toyobayashi toyobayashi mentioned this pull request Apr 22, 2023
Merged
targos pushed a commit that referenced this pull request May 2, 2023
@gabrielschulhof @targos
node-api: test passing NULL to number APIs
568256d 
PR-URL: #47549
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
@gabrielschulhof gabrielschulhof deleted the pass-null-to-number-apis branch May 20, 2023 01:05
@gabrielschulhof gabrielschulhof restored the pass-null-to-number-apis branch May 20, 2023 14:41
@gabrielschulhof gabrielschulhof deleted the pass-null-to-number-apis branch June 3, 2023 18:10
@gabrielschulhof gabrielschulhof restored the pass-null-to-number-apis branch June 5, 2023 02:21
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@gabrielschulhof @danielleadams
node-api: test passing NULL to number APIs
dee3245 
PR-URL: #47549
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@gabrielschulhof @MoLow
node-api: test passing NULL to number APIs
6ab8927 
PR-URL: nodejs#47549
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielschulhof @nodejs-github-bot @legendecas @mhdawson