[v19.x] src: bootstrap Web [Exposed=*] APIs in the shadow realm #47530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit splits the Web APIs bootstrapping and can be helpful to be backported to reduce conflicts, regardless of whether or not the last two commits are backported.
lib: distinguish webidl interfaces with the extended property "Exposed"
PR-URL: #46809
Refs: #42528
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Joyee Cheung [email protected]
src: bootstrap Web [Exposed=*] APIs in the shadow realm
This is the initial work to bootstrap Web interfaces that are defined
with extended attributes
[Exposed=*]
.The ShadowRealm instances are garbage-collected once it is
unreachable. However, V8 can not infer the reference cycles between
the per-realm strong persistent function handles and the realm's
context handle. To allow the context to be gc-ed once it is not
reachable, the per-realm persistent handles are attached to the
context's global object and the persistent handles are set as weak.
PR-URL: #46809
Refs: #42528
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Joyee Cheung [email protected]
test: move test-shadow-realm-gc.js to known_issues
There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.
PR-URL: #47355
Refs: #47353
Reviewed-By: Colin Ihrig [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: Yagiz Nizipli [email protected]