Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update simdutf to 3.2.7 #47473

Merged
merged 2 commits into from
Apr 10, 2023
Merged

deps: update simdutf to 3.2.7 #47473

merged 2 commits into from
Apr 10, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of simdutf to 3.2.7.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Apr 8, 2023
richardlau
richardlau reviewed Apr 8, 2023
View reviewed changes
deps/simdutf/simdutf.h Outdated
@@ -572,7 +574,7 @@ SIMDUTF_DISABLE_UNDESIRED_WARNINGS
#define SIMDUTF_SIMDUTF_VERSION_H

/** The version of simdutf being used (major.minor.revision) */
#define SIMDUTF_VERSION "3.2.3"
#define SIMDUTF_VERSION "3.2.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to match the PR/commit title (3.2.7)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lemire This seems to be wrong

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, it is how it is in the official repo 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. It should be fixed now.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 9, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51082/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51095/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 10, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/47473
✔  Done loading data for nodejs/node/pull/47473
----------------------------------- PR info ------------------------------------
Title      deps: update simdutf to 3.2.7 (#47473)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-simdutf -> nodejs:main
Labels     needs-ci, dependencies
Commits    2
 - deps: update simdutf to 3.2.7
 - deps: update simdutf to 3.2.7
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/47473
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47473
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 08 Apr 2023 00:11:22 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47473#pullrequestreview-1376821039
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47473#pullrequestreview-1376942709
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-04-09T18:21:22Z: https://ci.nodejs.org/job/node-test-pull-request/51095/
- Querying data for job/node-test-pull-request/51095/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47473
From https://github.com/nodejs/node
 * branch                  refs/pull/47473/merge -> FETCH_HEAD
✔  Fetched commits as 08e1564474b4..7660c33f1397
--------------------------------------------------------------------------------
[main 02469b654c] deps: update simdutf to 3.2.7
 Date: Sat Apr 8 00:11:19 2023 +0000
 2 files changed, 1029 insertions(+), 787 deletions(-)
[main 75499c15f5] deps: update simdutf to 3.2.7
 Date: Sun Apr 9 00:24:37 2023 +0000
 2 files changed, 4 insertions(+), 4 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

deps: update simdutf to 3.2.7


PR-URL: #47473

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Luigi Pinca [email protected]


[detached HEAD 3457778560] deps: update simdutf to 3.2.7

Date: Sat Apr 8 00:11:19 2023 +0000

2 files changed, 1029 insertions(+), 787 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

deps: update simdutf to 3.2.7


PR-URL: #47473

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Luigi Pinca [email protected]


[detached HEAD d7b458c6ba] deps: update simdutf to 3.2.7

Date: Sun Apr 9 00:24:37 2023 +0000

2 files changed, 4 insertions(+), 4 deletions(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/4659786927

@Trott Trott added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit fdee40e into main Apr 10, 2023
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-simdutf branch April 10, 2023 17:57
@nodejs-github-bot
Copy link
Collaborator Author

Landed in fdee40e

@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
This was referenced Apr 12, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@nodejs-github-bot @RafaelGSS
deps: update simdutf to 3.2.7
b66eb15 
PR-URL: #47473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@nodejs-github-bot @danielleadams
deps: update simdutf to 3.2.7
15a0084 
PR-URL: #47473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot @MoLow
deps: update simdutf to 3.2.7
d3b2e8a 
PR-URL: nodejs#47473
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@bricss bricss bricss left review comments

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nodejs-github-bot @lemire @lpinca @anonrig @bricss @richardlau @Trott