Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x backport] replace url parser with ada #47435

Closed
wants to merge 11 commits into from

Commits on Apr 11, 2023

  1. deps: add ada as a dependency

    PR-URL: nodejs#46410
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ea03c6f View commit details
    Browse the repository at this point in the history
  2. url: replace url-parser with ada

    PR-URL: nodejs#46410
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b227448 View commit details
    Browse the repository at this point in the history
  3. tools: fix update-ada script

    PR-URL: nodejs#46550
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0c9a8a1 View commit details
    Browse the repository at this point in the history
  4. deps: update ada to v1.0.1

    Co-authored-by: Daniel Lemire <[email protected]>
    PR-URL: nodejs#46550
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    anonrig and lemire committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    47e8f4e View commit details
    Browse the repository at this point in the history
  5. test: update web-platform tests for url

    PR-URL: nodejs#46547
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    78b3490 View commit details
    Browse the repository at this point in the history
  6. url: fix url spec compliance issues

    Co-authored-by: Daniel Lemire <[email protected]>
    PR-URL: nodejs#46547
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    anonrig and lemire committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    205678a View commit details
    Browse the repository at this point in the history
  7. url: improve performance by removing host

    PR-URL: nodejs#46547
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b2289da View commit details
    Browse the repository at this point in the history
  8. deps: update ada to 1.0.3

    PR-URL: nodejs#46784
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Tierney Cyren <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    nodejs-github-bot authored and anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a74ca49 View commit details
    Browse the repository at this point in the history
  9. deps: update ada to 1.0.4

    PR-URL: nodejs#46853
    Fixes: nodejs#46850
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Xuguang Mei <[email protected]>
    nodejs-github-bot authored and anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7df525b View commit details
    Browse the repository at this point in the history
  10. src: use string_view for report and related code

    Use `std::string_view` for process.report code and related
    code, drop a few unnecessary `std::to_string` calls,
    and use `MaybeStackBuffer` instead of `MallocedBuffer`,
    all in order to avoid unnecessary heap allocations.
    
    PR-URL: nodejs#46723
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    addaleax authored and anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    76fde06 View commit details
    Browse the repository at this point in the history
  11. url: simplify and improve url formatting

    PR-URL: nodejs#46736
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    aae4141 View commit details
    Browse the repository at this point in the history