Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: track ShadowRealm native objects correctly in the heap snapshot #47389

Merged
merged 1 commit into from
Apr 6, 2023
Merged

src: track ShadowRealm native objects correctly in the heap snapshot #47389

merged 1 commit into from
Apr 6, 2023

Commits on Apr 3, 2023

  1. src: track ShadowRealm native objects correctly in the heap snapshot 

    Previously the native ShadowRealm objects were never actually tracked
in the heap snapshot - the tracking starts with the Environment,
we don't call the tracking methods unless it's reachable natively from
the Environment. This patch adds a set in the Environment for tracking
shadow realms in the heap snapshot.

Drive-by: remove redundant MemoryInfo() overrides from the derived
classes of Realm and remove the tracking of `env` from
`Realm::MemoryInfo()` because the realms don't hold the Environment
alive (even for the principal realm, it's the other way around).
    @joyeecheung
    joyeecheung committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    06b7767 View commit details
    Browse the repository at this point in the history