Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: refactor v8_pch config #47364

Merged
merged 1 commit into from
May 28, 2023
Merged

tools: refactor v8_pch config #47364

merged 1 commit into from
May 28, 2023

Conversation

targos
Copy link
Member

@targos targos commented Apr 1, 2023

Avoid repetition by defining a new GYP target.

@targos targos added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Apr 1, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 1, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50790/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5265/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5265/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5265/

This was referenced Apr 2, 2023
Open
Open
Open
@targos
Copy link
Member Author

targos commented Apr 5, 2023

@gengjiawen ?

StefanStojanovic
StefanStojanovic approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos added request-ci Add this label to start a Jenkins CI on a PR. and removed v8 engine Issues and PRs related to the V8 dependency. labels Apr 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50958/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50967/

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51065/

@targos targos mentioned this pull request Apr 8, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51084/

@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Open
31 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51427/

@targos
tools: refactor v8_pch config
8dc0ba6 
Avoid repetition by defining a new GYP target.
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51746/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51749/

This was referenced May 11, 2023
Open
Open
Open
Open
Open
Open
Open
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit d81151e into nodejs:main May 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d81151e

@targos targos deleted the refactor-pch branch May 28, 2023 12:05
targos added a commit that referenced this pull request May 30, 2023
@targos
tools: refactor v8_pch config
568a705 
Avoid repetition by defining a new GYP target.

PR-URL: #47364
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
tools: refactor v8_pch config
85b5693 
Avoid repetition by defining a new GYP target.

PR-URL: nodejs#47364
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
tools: refactor v8_pch config
5c6bf8c 
Avoid repetition by defining a new GYP target.

PR-URL: nodejs#47364
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @tniessen @gengjiawen @richardlau @StefanStojanovic