-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib,src: replace toUSVString with toWellFormed()
#47342
lib,src: replace toUSVString with toWellFormed()
#47342
Conversation
Review requested:
|
cd7df60
to
80a3312
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Let's wait for #47340 to land to re-run the benchmark. |
I've re-run the benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1315/ |
b8411ac
to
357ef37
Compare
f69ddee
to
256ec34
Compare
Rebased and force pushed because of the flaky test. |
I noticed that f548b82 is split into a separate commit and the PR was labeled as
commit-queue-rebase
@anonrig would you mind removing the label
commit-queue-rebase
|
@legendecas done. can you review and add commit-queue? |
Commit Queue failed- Loading data for nodejs/node/pull/47342 ✔ Done loading data for nodejs/node/pull/47342 ----------------------------------- PR info ------------------------------------ Title lib,src: replace toUSVString with `toWellFormed()` (#47342) Author Yagiz Nizipli (@anonrig) Branch anonrig:to-usv-string-to-well-formed -> nodejs:main Labels semver-minor, lib / src, needs-ci, review wanted, commit-queue-squash, dont-land-on-v18.x Commits 3 - lib,src: replace toUSVString with `toWellFormed()` - benchmark: remove toUSVString benchmarks - fixup! lib,src: replace toUSVString with `toWellFormed()` Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/47342 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Matteo Collina Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47342 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Matteo Collina Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib,src: replace toUSVString with `toWellFormed()` ⚠ - benchmark: remove toUSVString benchmarks ⚠ - fixup! lib,src: replace toUSVString with `toWellFormed()` ℹ This PR was created on Fri, 31 Mar 2023 14:47:37 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47342#pullrequestreview-1367094432 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47342#pullrequestreview-1367545616 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/47342#pullrequestreview-1746692565 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/47342#pullrequestreview-1749539821 ✔ Last GitHub CI successful ℹ Last Benchmark CI on 2023-04-02T23:02:06Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1315/ ℹ Last Full PR CI on 2023-11-29T03:05:04Z: https://ci.nodejs.org/job/node-test-pull-request/55995/ - Querying data for job/node-test-pull-request/55995/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7032789935 |
Landed in 01dae5f |
PR-URL: #47342 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #47342 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Fixes #47328, depends on V8 11.3
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1315/