Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase timeout of wait for socket to be closed #47316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ywave620
Copy link
Contributor

For a passive closing socket, wait 100 ms for it to be closed.
Fix #47200

For a passive closing socket, wait 100 ms for it to be closed.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 30, 2023
@ywave620
Copy link
Contributor Author

100ms is enough for the stress test to paas in my mac.

roger@MacBook-Pro node-contribute % python3 tools/test.py parallel/test-http-remove-connection-header-persists-connection -j10 --repeat 1000
[00:47|% 100|+ 1000|-   0]: Done                                              

All tests passed.
roger@MacBook-Pro node-contribute % uname -a
Darwin MacBook-Pro.local 21.6.0 Darwin Kernel Version 21.6.0: Wed Aug 10 14:25:27 PDT 2022; root:xnu-8020.141.5~2/RELEASE_X86_64 x86_64
roger@MacBook-Pro node-contribute % 

@debadree25
Copy link
Member

debadree25 commented Apr 2, 2023

I think 50ms too would not be bad, just did some preliminary check it passed the stress test at 50 too, just want to optimise for the lowest number for which this wouldnt be flaky

@lpinca
Copy link
Member

lpinca commented Jun 23, 2023

I think this is no longer needed. The stress test passes on my mac.

$ ./tools/test.py -J --repeat=1000 test/parallel/test-http-remove-connection-header-persists-connection.js  
[00:12|% 100|+ 1000|-   0]: Done                                              

All tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test parallel/test-http-remove-connection-header-persists-connection
4 participants